'Re: Review Request: Blank label for folderview applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Blank label for folderview applet
From:       "Farhad Hedayati Fard" <hf.farhad () gmail ! com>
Date:       2011-02-26 16:43:22
Message-ID: 20110226164322.541.18664 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/
-----------------------------------------------------------

(Updated Feb. 26, 2011, 4:43 p.m.)

Review request for Plasma.

Summary
-------

Let the user set a blank label. The label should not take up any space when=
 it is blank.

Diffs
-----

  plasma/applets/folderview/folderview.h 2241b12 =

  plasma/applets/folderview/folderview.cpp f604277 =

  plasma/applets/folderview/folderviewDisplayConfig.ui 6568640 =

Diff: http://git.reviewboard.kde.org/r/100750/diff

Testing
-------

Works fine here! =

Screenshots
-----------

folderview configuration dialog
  http://git.reviewboard.kde.org/r/100750/s/84/
folderview with blank label
  http://git.reviewboard.kde.org/r/100750/s/85/

Thanks,

Farhad

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100750/">http://git.reviewboard.kde.org/r/100750/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Farhad Hedayati Fard.</div>

<p style="color: grey;"><i>Updated Feb. 26, 2011, 4:43 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Let the user set a blank label. The label should not take up any space \
when it is blank.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine here! </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applets/folderview/folderview.h <span style="color: \
grey">(2241b12)</span></li>

 <li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(f604277)</span></li>

 <li>plasma/applets/folderview/folderviewDisplayConfig.ui <span style="color: \
grey">(6568640)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100750/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/100750/s/84/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/26/folderview_settings_400x100.png" \
style="border: 1px black solid;" alt="folderview configuration dialog" /></a>

 <a href="http://git.reviewboard.kde.org/r/100750/s/85/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/26/folderview_400x100.png" \
style="border: 1px black solid;" alt="folderview with blank label" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 