[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make DBusMenuQt optional
From: "Nick Shaforostoff" <shaforostoff () gmail ! com>
Date: 2011-02-26 15:22:38
Message-ID: 20110226152238.21560.47408 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4898/#review9913
-----------------------------------------------------------
Ship it!
what's the status of this patch for KDE 4.6?
it makes compiling on windows hard
- Nick
On Aug. 6, 2010, 12:34 p.m., Marc Mutz wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4898/
> -----------------------------------------------------------
> =
> (Updated Aug. 6, 2010, 12:34 p.m.)
> =
> =
> Review request for kdelibs, Plasma and Marco Martin.
> =
> =
> Summary
> -------
> =
> Make DBusMenuQt optional.
> =
> =
> Diffs
> -----
> =
> /branches/KDE/4.5/kdebase/workspace/CMakeLists.txt 1159836 =
> /branches/KDE/4.5/kdebase/workspace/ConfigureChecks.cmake 1159836 =
> /branches/KDE/4.5/kdebase/workspace/config-workspace.h.cmake 1159836 =
> /branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusno=
tifieritem/CMakeLists.txt 1159836 =
> /branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusno=
tifieritem/statusnotifieritemsource.cpp 1159836 =
> /branches/KDE/4.5/kdelibs/CMakeLists.txt 1159039 =
> /branches/KDE/4.5/kdelibs/ConfigureChecks.cmake 1159039 =
> /branches/KDE/4.5/kdelibs/config.h.cmake 1159039 =
> /branches/KDE/4.5/kdelibs/kdeui/CMakeLists.txt 1159039 =
> /branches/KDE/4.5/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp 1=
159039 =
> =
> Diff: http://svn.reviewboard.kde.org/r/4898/diff
> =
> =
> Testing
> -------
> =
> Compiles w/o DBusMenuQt present.
> =
> =
> Thanks,
> =
> Marc
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4898/">http://svn.reviewboard.kde.org/r/4898/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what's the status of \
this patch for KDE 4.6?
it makes compiling on windows hard</pre>
<br />
<p>- Nick</p>
<br />
<p>On August 6th, 2010, 12:34 p.m., Marc Mutz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Plasma and Marco Martin.</div>
<div>By Marc Mutz.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2010, 12:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make DBusMenuQt optional.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles w/o DBusMenuQt present.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.5/kdebase/workspace/CMakeLists.txt <span style="color: \
grey">(1159836)</span></li>
<li>/branches/KDE/4.5/kdebase/workspace/ConfigureChecks.cmake <span style="color: \
grey">(1159836)</span></li>
<li>/branches/KDE/4.5/kdebase/workspace/config-workspace.h.cmake <span style="color: \
grey">(1159836)</span></li>
<li>/branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt \
<span style="color: grey">(1159836)</span></li>
<li>/branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/statusnotifieritem/statusnotifieritemsource.cpp \
<span style="color: grey">(1159836)</span></li>
<li>/branches/KDE/4.5/kdelibs/CMakeLists.txt <span style="color: \
grey">(1159039)</span></li>
<li>/branches/KDE/4.5/kdelibs/ConfigureChecks.cmake <span style="color: \
grey">(1159039)</span></li>
<li>/branches/KDE/4.5/kdelibs/config.h.cmake <span style="color: \
grey">(1159039)</span></li>
<li>/branches/KDE/4.5/kdelibs/kdeui/CMakeLists.txt <span style="color: \
grey">(1159039)</span></li>
<li>/branches/KDE/4.5/kdelibs/kdeui/notifications/kstatusnotifieritem.cpp <span \
style="color: grey">(1159039)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4898/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic