[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: ClockApplet : show seconds in the tooltip
From: "Iamluc" <luc () vieillescazes ! net>
Date: 2011-02-05 14:26:51
Message-ID: 20110205142651.652.35799 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6336/
-----------------------------------------------------------
(Updated Feb. 5, 2011, 2:26 p.m.)
Review request for Plasma.
Changes
-------
Hi,
I followed Aaron comments :
* rename ClockTimer to something clearer -> ClockToolTip?
---> Done
* have ClockToolTip subclass both QObject and Plasma::ToolTipContent
--> Done
* move updateToolTip into ClockToolTip, renamed as dataUpdated(const QStrin=
g &source, const Plasma::DataEngine &data) ;)
--> Done, and move function addTzToTipText() too.
* connect to the dataengine on creation of ClockToolTip
--> Done
* create a ClockToolTip object when toolTipAboutToShow is called
* delete it in toolTipHidden
--> Both done
* pass in the ClockApplet as the parent to ClockToolTip and then in ClockTo=
olTip::dataUpdated, set the mainText and then call Plasma::ToolTipManager::=
self()->setContent(clockApplet, this)
--> Done
Summary
-------
Hi,
When using a clock applet, seconds are often not visibles. But sometimes yo=
u need them.
This patch shows them in the tooltip of the applet.
Analog-clock has been updated to refresh the tooltip every seconds.
If this change is accepted, I could change digital-clock
Thanks !
Diffs (updated)
-----
/trunk/KDE/kdebase/workspace/libs/plasmaclock/CMakeLists.txt 1217808 =
/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 1217808 =
/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 1217808 =
/trunk/KDE/kdebase/workspace/libs/plasmaclock/clocktooltip.h PRE-CREATION =
/trunk/KDE/kdebase/workspace/libs/plasmaclock/clocktooltip.cpp PRE-CREATI=
ON =
Diff: http://svn.reviewboard.kde.org/r/6336/diff
Testing
-------
It Works on plasmoidviewer and with a real session
Thanks,
Iamluc
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6336/">http://svn.reviewboard.kde.org/r/6336/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Iamluc.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2011, 2:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
I followed Aaron comments :
* rename ClockTimer to something clearer -> ClockToolTip?
---> Done
* have ClockToolTip subclass both QObject and Plasma::ToolTipContent
--> Done
* move updateToolTip into ClockToolTip, renamed as dataUpdated(const QString \
&source, const Plasma::DataEngine &data) ;)
--> Done, and move function addTzToTipText() too.
* connect to the dataengine on creation of ClockToolTip
--> Done
* create a ClockToolTip object when toolTipAboutToShow is called
* delete it in toolTipHidden
--> Both done
* pass in the ClockApplet as the parent to ClockToolTip and then in \
ClockToolTip::dataUpdated, set the mainText and then call \
Plasma::ToolTipManager::self()->setContent(clockApplet, this)
--> Done
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
When using a clock applet, seconds are often not visibles. But sometimes you need \
them. This patch shows them in the tooltip of the applet.
Analog-clock has been updated to refresh the tooltip every seconds.
If this change is accepted, I could change digital-clock
Thanks !</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It Works on plasmoidviewer and with a real session</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/CMakeLists.txt <span style="color: \
grey">(1217808)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h <span style="color: \
grey">(1217808)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp <span \
style="color: grey">(1217808)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/clocktooltip.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/clocktooltip.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6336/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic