[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: ClockApplet : show seconds in the tooltip
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2011-01-29 18:53:55
Message-ID: 20110129185355.30886.64512 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6336/#review9760
-----------------------------------------------------------


a good step in the right direction, but it's still needs work.

looking at the approach taken, i'd probably do this:

* rename ClockTimer to something clearer -> ClockToolTip?
* have ClockToolTip subclass both QObject and Plasma::ToolTipContent
* move updateToolTip into ClockToolTip, renamed as dataUpdated(const QStrin=
g &source, const Plasma::DataEngine &data) ;)
* connect to the dataengine on creation of ClockToolTip
* create a ClockToolTip object when toolTipAboutToShow is called
* delete it in toolTipHidden
* pass in the ClockApplet as the parent to ClockToolTip and then in ClockTo=
olTip::dataUpdated, set the mainText and then call Plasma::ToolTipManager::=
self()->setContent(clockApplet, this)

that means that ClockApplet::updateToolTip would no long be available to su=
bclasses, but that's ok because they were only using it to update the toolt=
ip when the time changed ... which ClockApplet would now be doing for them.


/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp
<http://svn.reviewboard.kde.org/r/6336/#comment10905>

    this will interfere with any clock applet (which is all of them) which =
implements dataUpdated.
    =

    moreover, calling updateTipContent without the data passed in, only to =
discard it seems wasteful.


- Aaron


On Jan. 29, 2011, 2:15 p.m., Iamluc wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6336/
> -----------------------------------------------------------
> =

> (Updated Jan. 29, 2011, 2:15 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> Hi,
> =

> When using a clock applet, seconds are often not visibles. But sometimes =
you need them.
> This patch shows them in the tooltip of the applet.
> =

> Analog-clock has been updated to refresh the tooltip every seconds.
> If this change is accepted, I could change digital-clock
> =

> Thanks !
> =

> =

> Diffs
> -----
> =

>   /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 1217808 =

>   /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 1217808 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6336/diff
> =

> =

> Testing
> -------
> =

> It Works on plasmoidviewer and with a real session
> =

> =

> Thanks,
> =

> Iamluc
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6336/">http://svn.reviewboard.kde.org/r/6336/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a good step in the right \
direction, but it&#39;s still needs work.

looking at the approach taken, i&#39;d probably do this:

* rename ClockTimer to something clearer -&gt; ClockToolTip?
* have ClockToolTip subclass both QObject and Plasma::ToolTipContent
* move updateToolTip into ClockToolTip, renamed as dataUpdated(const QString \
                &amp;source, const Plasma::DataEngine &amp;data) ;)
* connect to the dataengine on creation of ClockToolTip
* create a ClockToolTip object when toolTipAboutToShow is called
* delete it in toolTipHidden
* pass in the ClockApplet as the parent to ClockToolTip and then in \
ClockToolTip::dataUpdated, set the mainText and then call \
Plasma::ToolTipManager::self()-&gt;setContent(clockApplet, this)

that means that ClockApplet::updateToolTip would no long be available to subclasses, \
but that&#39;s ok because they were only using it to update the tooltip when the time \
changed ... which ClockApplet would now be doing for them.</pre>  <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6336/diff/3/?file=44609#file44609line264" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void ClockApplet::connectToEngine()</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">264</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">ClockApplet</span><span \
class="o">::</span><span class="n">dataUpdated</span><span class="p">(</span><span \
class="k">const</span> <span class="n">QString</span><span class="o">&amp;</span> \
<span class="n">source</span><span class="p">,</span> <span class="k">const</span> \
<span class="n">Plasma</span><span class="o">::</span><span \
class="n">DataEngine</span><span class="o">::</span><span class="n">Data</span> <span \
class="o">&amp;</span><span class="n">data</span><span class="p">)</span></pre></td>  \
</tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">265</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">266</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">updateTipContent</span><span class="p">();</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">267</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">}</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this will \
interfere with any clock applet (which is all of them) which implements dataUpdated.

moreover, calling updateTipContent without the data passed in, only to discard it \
seems wasteful.</pre> </div>
<br />



<p>- Aaron</p>


<br />
<p>On January 29th, 2011, 2:15 p.m., Iamluc wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Iamluc.</div>


<p style="color: grey;"><i>Updated Jan. 29, 2011, 2:15 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,

When using a clock applet, seconds are often not visibles. But sometimes you need \
them. This patch shows them in the tooltip of the applet.

Analog-clock has been updated to refresh the tooltip every seconds.
If this change is accepted, I could change digital-clock

Thanks !</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It Works on plasmoidviewer and with a real session</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h <span style="color: \
grey">(1217808)</span></li>

 <li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp <span \
style="color: grey">(1217808)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6336/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic