'Review Request: Adding "Set Wallpaper Image" Option in Picture Frame'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Adding "Set Wallpaper Image" Option in Picture Frame
From:       "Sinny Kumari" <ksinny () gmail ! com>
Date:       2011-01-26 16:20:08
Message-ID: 20110126162008.20280.40549 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6416/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

Including this patch and other two (http://svn.reviewboard.kde.org/r/6375/ =
, http://reviewboard.kde.org/r/6391/ ) , It adds "Set Wallpaper Image" feat=
ure in Picture Frame. If the User right clicks on Picture Frame, there will=
 be an option "Set Wallpaper Image". This Option will set the current Image=
 Of Picture
Frame as Wallpaper Image.

Diffs
-----

  trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1216449 =

  trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1216449 =

Diff: http://svn.reviewboard.kde.org/r/6416/diff

Testing
-------

Setting Picture Frame Image as wallpaper Image in all cases. Added QTimer i=
n method Frame::setImageAsWallpaper() in Order to work properly in case of =
Wallpaper other than Image and Slideshow. If there is better solution than =
using QTimer, please suggest :)

Thanks,

Sinny

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6416/">http://svn.reviewboard.kde.org/r/6416/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Including this patch and other two \
(http://svn.reviewboard.kde.org/r/6375/ , http://reviewboard.kde.org/r/6391/ ) , It \
adds &quot;Set Wallpaper Image&quot; feature in Picture Frame. If the User right \
clicks on Picture Frame, there will be an option &quot;Set Wallpaper Image&quot;. \
This Option will set the current Image Of Picture Frame as Wallpaper Image.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Setting Picture Frame Image as wallpaper Image in all cases. Added \
QTimer in method Frame::setImageAsWallpaper() in Order to work properly in case of \
Wallpaper other than Image and Slideshow. If there is better solution than using \
QTimer, please suggest :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdeplasma-addons/applets/frame/frame.h <span style="color: \
grey">(1216449)</span></li>

 <li>trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp <span style="color: \
grey">(1216449)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6416/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 