'Re: Review Request: Overrides Plasma::wallpaer method addUrls() to'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Overrides Plasma::wallpaer method addUrls() to
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2011-01-25 19:54:24
Message-ID: 20110125195424.16542.7143 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6391/#review9725
-----------------------------------------------------------

Ship it!

- Aaron

On Jan. 25, 2011, 7:49 p.m., Sinny Kumari wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6391/
> -----------------------------------------------------------
> =

> (Updated Jan. 25, 2011, 7:49 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

>  Method addUrls(const KUrl::List &urls) which is protected Q_SLOTS will o=
verride the method defined ( changes that have been made in http://svn.revi=
ewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to set Image.=
 After reviewing it I will implement both changes in Frame Applet :)
> =

> =

> Diffs
> -----
> =

>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 121=
6449 =

>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1=
216449 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6391/diff
> =

> =

> Testing
> -------
> =

> Tested in trunk and it works perfectly.
> =

> =

> Thanks,
> =

> Sinny
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6391/">http://svn.reviewboard.kde.org/r/6391/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- Aaron</p>

<br />
<p>On January 25th, 2011, 7:49 p.m., Sinny Kumari wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>

<p style="color: grey;"><i>Updated Jan. 25, 2011, 7:49 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Method addUrls(const KUrl::List &amp;urls) which is protected Q_SLOTS \
will override the method defined ( changes that have been made in \
http://svn.reviewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to set \
Image. After reviewing it I will implement both changes in Frame Applet :)</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in trunk and it works perfectly.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h <span \
style="color: grey">(1216449)</span></li>

 <li>trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp <span \
style="color: grey">(1216449)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6391/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 