'Re: Review Request: Make wallpaper capable of setting particular Image'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Make wallpaper capable of setting particular Image
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2011-01-20 19:42:31
Message-ID: 20110120194231.26842.29651 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6375/#review9659
-----------------------------------------------------------

Ship it!

after last revision is perfect, go for it.

- Marco

On Jan. 20, 2011, 7:36 p.m., Sinny Kumari wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6375/
> -----------------------------------------------------------
> =

> (Updated Jan. 20, 2011, 7:36 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> According to suggestion given by Aaron (refer to mailing list thread http=
://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have d=
one changes in trunk/KDE/kdelibs/plasma/. I have added functions setUrls(co=
nst KUrl::List &urls) as public function and addUrls(const KUrl::List &urls=
) as protected Q_SLOTS in it so that setUrls() can be invoked from frame ap=
plet. There are more patches to come, after this one gets approved.
> =

> =

> Diffs
> -----
> =

>   trunk/KDE/kdelibs/plasma/wallpaper.h 1215563 =

>   trunk/KDE/kdelibs/plasma/wallpaper.cpp 1215563 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6375/diff
> =

> =

> Testing
> -------
> =

> Tested in trunk and everything is working fine.
> =

> =

> Thanks,
> =

> Sinny
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6375/">http://svn.reviewboard.kde.org/r/6375/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">after last revision is \
perfect, go for it.</pre>  <br />

<p>- Marco</p>

<br />
<p>On January 20th, 2011, 7:36 p.m., Sinny Kumari wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>

<p style="color: grey;"><i>Updated Jan. 20, 2011, 7:36 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">According to suggestion given by Aaron (refer to mailing list thread \
http://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have done \
changes in trunk/KDE/kdelibs/plasma/. I have added functions setUrls(const KUrl::List \
&amp;urls) as public function and addUrls(const KUrl::List &amp;urls) as protected \
Q_SLOTS in it so that setUrls() can be invoked from frame applet. There are more \
patches to come, after this one gets approved.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested in trunk and everything is working fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdelibs/plasma/wallpaper.h <span style="color: \
grey">(1215563)</span></li>

 <li>trunk/KDE/kdelibs/plasma/wallpaper.cpp <span style="color: \
grey">(1215563)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6375/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 