--===============1314416890== Content-Type: multipart/alternative; boundary="===============6681783545268910252==" --===============6681783545268910252== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6375/#review9659 ----------------------------------------------------------- Ship it! after last revision is perfect, go for it. - Marco On Jan. 20, 2011, 7:36 p.m., Sinny Kumari wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6375/ > ----------------------------------------------------------- > = > (Updated Jan. 20, 2011, 7:36 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > According to suggestion given by Aaron (refer to mailing list thread http= ://mail.kde.org/pipermail/plasma-devel/2011-January/014610.html ), I have d= one changes in trunk/KDE/kdelibs/plasma/. I have added functions setUrls(co= nst KUrl::List &urls) as public function and addUrls(const KUrl::List &urls= ) as protected Q_SLOTS in it so that setUrls() can be invoked from frame ap= plet. There are more patches to come, after this one gets approved. > = > = > Diffs > ----- > = > trunk/KDE/kdelibs/plasma/wallpaper.h 1215563 = > trunk/KDE/kdelibs/plasma/wallpaper.cpp 1215563 = > = > Diff: http://svn.reviewboard.kde.org/r/6375/diff > = > = > Testing > ------- > = > Tested in trunk and everything is working fine. > = > = > Thanks, > = > Sinny > = > --===============6681783545268910252== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6375/

Ship it!

after last=
 revision is perfect, go for it.

- Marco

On January 20th, 2011, 7:36 p.m., Sinny Kumari wrote:

Review request for Plasma.

By Sinny Kumari.

Updated Jan. 20, 2011, 7:36 p.m.

Descripti= on

According to suggestion given by Aaron (refer to mailing lis=
t thread http://mail.kde.org/pipermail/plasma-devel/2011-January/014610.htm=
l ), I have done changes in trunk/KDE/kdelibs/plasma/. I have added functio=
ns setUrls(const KUrl::List &urls) as public function and addUrls(const=
 KUrl::List &urls) as protected Q_SLOTS in it so that setUrls() can be =
invoked from frame applet. There are more patches to come, after this one g=
ets approved.

Testing <= /h1>

Tested in trunk and everything is working fine.

Diffs=

trunk/KDE/kdelibs/plasma/wallpaper.h (1215= 563)
trunk/KDE/kdelibs/plasma/wallpaper.cpp (12= 15563)

View Diff

--===============6681783545268910252==-- --===============1314416890== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1314416890==--