'Re: Review Request: Mime-type in NepomukSearchRunner'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Mime-type in NepomukSearchRunner
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2011-01-16 19:34:20
Message-ID: 20110116193420.5065.48548 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6338/#review9639
-----------------------------------------------------------

some code style issues, but otherwise looks good.

/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomukse=
archrunner.cpp
<http://svn.reviewboard.kde.org/r/6338/#comment10664>

    these should go at the top of the file with the other includes. prefera=
bly using the CamelCase style, e.g. #include <KMimeType>

/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomukse=
archrunner.cpp
<http://svn.reviewboard.kde.org/r/6338/#comment10665>

    no spaces before/after ()s

/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomukse=
archrunner.cpp
<http://svn.reviewboard.kde.org/r/6338/#comment10666>

    whitespace

/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/queryclie=
ntwrapper.cpp
<http://svn.reviewboard.kde.org/r/6338/#comment10667>

    whitespace after (s and before )s should be removed

- Aaron

On Jan. 16, 2011, 9:47 a.m., Amir Pakdel wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6338/
> -----------------------------------------------------------
> =

> (Updated Jan. 16, 2011, 9:47 a.m.)
> =

> =

> Review request for Plasma, Sebastian Trueg and Vishesh Handa.
> =

> =

> Summary
> -------
> =

> I have changed NepomukSearchRunner a little bit, so I could search for co=
ntents of notes (added by BasketNotepad) using KRunner.
> =

> It uses NIE:mimeType of the resource to set the "type" and "iconName" of =
the search result. If the resourse does not have NIE:mimeType property, KMi=
meType::findByUrl(url) is used instead (in order to find the mime-type asso=
ciated with the url of the resource).
> =

> When running/opening the search result, preferredService of the mime-type=
 is used in invokation of KRun::run; therefore, the mime-type of the resour=
ce (or its url) indicates the service that would be used to run the resourc=
e.
> =

> =

> Diffs
> -----
> =

>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepom=
uksearchrunner.cpp 1193800 =

>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/query=
clientwrapper.cpp 1193800 =

> =

> Diff: http://svn.reviewboard.kde.org/r/6338/diff
> =

> =

> Testing
> -------
> =

> I have searched for contents of notes that were added by BasketNotepad (u=
sing KRunner) and opened them in BasketNotepads.
> =

> =

> Thanks,
> =

> Amir
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6338/">http://svn.reviewboard.kde.org/r/6338/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">some code style issues, \
but otherwise looks good.</pre>  <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6338/diff/1/?file=44267#file44267line118" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp</a>
  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Nepomuk::SearchRunner::match( Plasma::RunnerContext&amp; context )</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">118</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include &lt;kmimetype.h&gt;</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">119</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include &lt;kmimetypetrader.h&gt;</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">120</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include &lt;kservice.h&gt;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">these \
should go at the top of the file with the other includes. preferably using the \
CamelCase style, e.g. #include &lt;KMimeType&gt;</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6338/diff/1/?file=44267#file44267line142" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp</a>
  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Nepomuk::SearchRunner::run( const Plasma::RunnerContext&amp;, const \
Plasma::QueryMatch&amp; match )</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">142</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">preferredServicePtr</span> <span class="o">=</span> <span \
class="n">KMimeTypeTrader</span><span class="o">::</span><span \
class="n">self</span><span class="p">()</span><span class="o">-&gt;</span><span \
class="n">preferredService</span><span class="p">(</span> <span \
class="n">res</span><span class="p">.</span><span class="n">property</span><span \
class="p">(</span><span class="n">Nepomuk</span><span class="o">::</span><span \
class="n">Vocabulary</span><span class="o">::</span><span class="n">NIE</span><span \
class="o">::</span><span class="n">mimeType</span><span class="p">()).</span><span \
class="n">toString</span><span class="p">()</span> <span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no spaces \
before/after ()s</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6338/diff/1/?file=44267#file44267line145" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp</a>
  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Nepomuk::SearchRunner::run( const Plasma::RunnerContext&amp;, const \
Plasma::QueryMatch&amp; match )</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">145</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span> <span \
class="n">preferredServicePtr</span><span class="p">.</span><span \
class="n">isNull</span><span class="p">()</span> <span class="o">||</span> <span \
class="o">!</span> <span class="n">KRun</span><span class="o">::</span><span \
class="n">run</span><span class="p">(</span> <span class="o">*</span><span \
class="n">preferredServicePtr</span><span class="p">.</span><span \
class="n">constData</span><span class="p">(),</span> <span class="n">KUrl</span><span \
class="o">::</span><span class="n">List</span><span class="p">(</span><span \
class="n">url</span><span class="p">),</span> <span class="mi">0</span><span \
class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">whitespace</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/6338/diff/1/?file=44268#file44268line106" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp</a>
  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Nepomuk::QueryClientWrapper::slotNewEntries(const \
QList&lt;Nepomuk::Query::Result&gt;&amp; results)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">106</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">if</span> <span class="p">(</span> <span class="n">res</span><span \
class="p">.</span><span class="n">hasProperty</span><span class="p">(</span><span \
class="n">Nepomuk</span><span class="o">::</span><span \
class="n">Vocabulary</span><span class="o">::</span><span class="n">NIE</span><span \
class="o">::</span><span class="n">mimeType</span><span class="p">())</span> <span \
class="p">)</span> <span class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">107</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="n">mimetype</span> <span class="o">=</span> <span \
class="n">KMimeType</span><span class="o">::</span><span \
class="n">mimeType</span><span class="p">(</span> <span class="n">res</span><span \
class="p">.</span><span class="n">property</span><span class="p">(</span><span \
class="n">Nepomuk</span><span class="o">::</span><span \
class="n">Vocabulary</span><span class="o">::</span><span class="n">NIE</span><span \
class="o">::</span><span class="n">mimeType</span><span class="p">()).</span><span \
class="n">toString</span><span class="p">()</span> <span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">whitespace \
after (s and before )s should be removed</pre> </div>
<br />

<p>- Aaron</p>

<br />
<p>On January 16th, 2011, 9:47 a.m., Amir Pakdel wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Sebastian Trueg and Vishesh Handa.</div>
<div>By Amir Pakdel.</div>

<p style="color: grey;"><i>Updated Jan. 16, 2011, 9:47 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have changed NepomukSearchRunner a little bit, so I could search for \
contents of notes (added by BasketNotepad) using KRunner.

It uses NIE:mimeType of the resource to set the &quot;type&quot; and \
&quot;iconName&quot; of the search result. If the resourse does not have NIE:mimeType \
property, KMimeType::findByUrl(url) is used instead (in order to find the mime-type \
associated with the url of the resource).

When running/opening the search result, preferredService of the mime-type is used in \
invokation of KRun::run; therefore, the mime-type of the resource (or its url) \
indicates the service that would be used to run the resource.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have searched for contents of notes that were added by BasketNotepad \
(using KRunner) and opened them in BasketNotepads.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp \
<span style="color: grey">(1193800)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp \
<span style="color: grey">(1193800)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6338/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 