[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: ClockApplet : show seconds in the tooltip
From: "Aaron Seigo" <aseigo () kde ! org>
Date: 2011-01-16 18:41:49
Message-ID: 20110116184149.3663.3007 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 15, 2011, 8:08 p.m., Aaron Seigo wrote:
> > i agree with Marco, that this should end up in the ClockApplet class sh=
ared by all clocks.
> > =
> > the way this probably will need to be done is to have a QObject with a =
dataUpdated method used for this purpose in ClockApplet that is connected/d=
isconnected to the time engine using the current timezone on toolTipAboutTo=
Show/Hide. then it will work with all clocks.
> =
> Marco Martin wrote:
> yeah, i like the idea.
> this maybe suggests it's also time to make DataEngineConsumer public =
API in libplasma.
> make DataEngineConsumer public API in libplasma
yes, it could be. taking it one step further: perhaps in libplasma2 DataEng=
ineManager goes private (further protecting the usage of DataEngines; we've=
seen some bugs in C++ in the past due to using DataEngineManager directly =
and incorrectly) and DataEngineConsumer becomes a public interface instead.
that said, in this case, ClockApplet can simply pass the return from dataEn=
gine("time") into the QObject.
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6336/#review9635
-----------------------------------------------------------
On Jan. 15, 2011, 3:17 p.m., Iamluc wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6336/
> -----------------------------------------------------------
> =
> (Updated Jan. 15, 2011, 3:17 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Hi,
> =
> When using a clock applet, seconds are often not visibles. But sometimes =
you need them.
> This patch shows them in the tooltip of the applet.
> =
> Analog-clock has been updated to refresh the tooltip every seconds.
> If this change is accepted, I could change digital-clock
> =
> Thanks !
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 1214556 =
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.=
h 1214556 =
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.=
cpp 1214556 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6336/diff
> =
> =
> Testing
> -------
> =
> It Works on plasmoidviewer and with a real session
> =
> =
> Thanks,
> =
> Iamluc
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6336/">http://svn.reviewboard.kde.org/r/6336/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 15th, 2011, 8:08 p.m., <b>Aaron \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i agree with Marco, that this should end up in the ClockApplet class \
shared by all clocks.
the way this probably will need to be done is to have a QObject with a dataUpdated \
method used for this purpose in ClockApplet that is connected/disconnected to the \
time engine using the current timezone on toolTipAboutToShow/Hide. then it will work \
with all clocks.</pre> </blockquote>
<p>On January 16th, 2011, 9:40 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yeah, i like the idea. \
this maybe suggests it's also time to make DataEngineConsumer public API in \
libplasma.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> make \
DataEngineConsumer public API in libplasma
yes, it could be. taking it one step further: perhaps in libplasma2 DataEngineManager \
goes private (further protecting the usage of DataEngines; we've seen some bugs \
in C++ in the past due to using DataEngineManager directly and incorrectly) and \
DataEngineConsumer becomes a public interface instead.
that said, in this case, ClockApplet can simply pass the return from \
dataEngine("time") into the QObject.</pre> <br />
<p>- Aaron</p>
<br />
<p>On January 15th, 2011, 3:17 p.m., Iamluc wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Iamluc.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2011, 3:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
When using a clock applet, seconds are often not visibles. But sometimes you need \
them. This patch shows them in the tooltip of the applet.
Analog-clock has been updated to refresh the tooltip every seconds.
If this change is accepted, I could change digital-clock
Thanks !</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It Works on plasmoidviewer and with a real session</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp <span \
style="color: grey">(1214556)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h <span \
style="color: grey">(1214556)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp <span \
style="color: grey">(1214556)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6336/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic