[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Display applet context menu when the label hasn't
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-11-29 16:26:29
Message-ID: 20101129162629.4378.57786 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6009/#review9040
-----------------------------------------------------------
Ship it!
i think it could work. let's see how it goes
trunk/KDE/kdelibs/plasma/widgets/label.cpp
<http://svn.reviewboard.kde.org/r/6009/#comment9792>
i wonder if should be necessary to check some other flag like linkacces=
siblebymouse..
in general it could work.
- Marco
On 2010-11-29 16:24:16, Davide Bettio wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6009/
> -----------------------------------------------------------
> =
> (Updated 2010-11-29 16:24:16)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> If there isn't any label context menu to show the event is ignored. It ma=
kes sense to show a context menu only when the text can be selected or when=
there is a link.
> This patch improves usability of applets which they have a lot of labels =
(like the weather plasmoid) or applets with huge labels (like the calculato=
r).
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdelibs/plasma/widgets/label.cpp 1202069 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6009/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Davide
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6009/">http://svn.reviewboard.kde.org/r/6009/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think it could work. \
let's see how it goes</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6009/diff/1/?file=41830#file41830line233" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdelibs/plasma/widgets/label.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Label::contextMenuEvent(QGraphicsSceneContextMenuEvent *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">233</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">{</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">233</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="p">{</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">234</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">d</span><span \
class="o">-></span><span class="n">textSelectable</span> <span class="o">||</span> \
<span class="n">nativeWidget</span><span class="p">()</span><span \
class="o">-></span><span class="n">text</span><span class="p">().</span><span \
class="n">contains</span><span class="p">(</span><span class="s">"<a \
"</span><span class="p">,</span> <span class="n">Qt</span><span \
class="o">::</span><span class="n">CaseInsensitive</span><span \
class="p">)){</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i wonder if \
should be necessary to check some other flag like linkaccessiblebymouse.. in general \
it could work.</pre> </div>
<br />
<p>- Marco</p>
<br />
<p>On November 29th, 2010, 4:24 p.m., Davide Bettio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Davide Bettio.</div>
<p style="color: grey;"><i>Updated 2010-11-29 16:24:16</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If there isn't any label context menu to show the event is ignored. \
It makes sense to show a context menu only when the text can be selected or when \
there is a link. This patch improves usability of applets which they have a lot of \
labels (like the weather plasmoid) or applets with huge labels (like the calculator). \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/widgets/label.cpp <span style="color: \
grey">(1202069)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6009/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic