--===============0816912971== Content-Type: multipart/alternative; boundary="===============4387865657706753834==" --===============4387865657706753834== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6009/#review9040 ----------------------------------------------------------- Ship it! i think it could work. let's see how it goes trunk/KDE/kdelibs/plasma/widgets/label.cpp i wonder if should be necessary to check some other flag like linkacces= siblebymouse.. in general it could work. - Marco On 2010-11-29 16:24:16, Davide Bettio wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6009/ > ----------------------------------------------------------- > = > (Updated 2010-11-29 16:24:16) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > If there isn't any label context menu to show the event is ignored. It ma= kes sense to show a context menu only when the text can be selected or when= there is a link. > This patch improves usability of applets which they have a lot of labels = (like the weather plasmoid) or applets with huge labels (like the calculato= r). > = > = > Diffs > ----- > = > trunk/KDE/kdelibs/plasma/widgets/label.cpp 1202069 = > = > Diff: http://svn.reviewboard.kde.org/r/6009/diff > = > = > Testing > ------- > = > = > Thanks, > = > Davide > = > --===============4387865657706753834== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6009/

Ship it!

i think it=
 could work. let's see how it goes

= = = =
trunk/KDE/kdelibs/plasma/widgets/label.cpp (Diff revision 1) 
void Label::contextMenuEvent(QGraphicsSceneContextMenuEvent *event)=
233 
{
 233 
{
 

    234
    
    if (d->textSelectable || nativeWidget()->text().contains("<=
;a ", Qt::CaseInsensitive)){

  


 





i wonder if should be necessary to check some other flag like linkac=
cessiblebymouse..
in general it could work.









- Marco






On November 29th, 2010, 4:24 p.m., Davide Bettio wrote:









 

  


Review request for Plasma.


By Davide Bettio.




Updated 2010-11-29 16:24:16






Descripti=
on 



 

  
   
If there isn't any label context menu to show the event =
is ignored. It makes sense to show a context menu only when the text can be=
 selected or when there is a link.
This patch improves usability of applets which they have a lot of labels (l=
ike the weather plasmoid) or applets with huge labels (like the calculator).


  		
 









Diffs=
 


    

 
  • trunk/KDE/kdelibs/plasma/widgets/label.cpp (1202069)
    • 





View Diff





  		
 











  

 



--===============4387865657706753834==--

--===============0816912971==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============0816912971==--