[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Save the notification position in relation to the
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-11-20 20:16:38
Message-ID: 20101120201638.9798.78193 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5914/#review8868
-----------------------------------------------------------
/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackd=
ialog.h
<http://svn.reviewboard.kde.org/r/5914/#comment9503>
i think this should be bore adjustedSavedPos()
=
toReal looks more converting to a uhm real :)
- Marco
On 2010-11-20 19:34:11, Alex Fiestas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5914/
> -----------------------------------------------------------
> =
> (Updated 2010-11-20 19:34:11)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Summary
> -------
> =
> Currently we're saving the notifications using absolute positions, becaus=
e of this the notification is misplaced if the resolution changes, or the d=
esktop is extended with another monitor.
> =
> This patch changes the way the position is saved, by doing it measuring t=
he space between the notification and the screen borders. For example if we=
place the notification 10px from bottom and 10px from right, no matters ho=
w the screen configuration changes, it will be always placed 10px bottom 10=
px right.
> =
> The only thing left to handle properly is "center" the notification just =
like KRunner does, but that will be another patch.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/st=
ackdialog.h 1198889 =
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/st=
ackdialog.cpp 1198889 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5914/diff
> =
> =
> Testing
> -------
> =
> I tried to misplace the notification by changing the resolution, added/re=
moving displays and so far everything has worked well.
> =
> =
> Thanks,
> =
> Alex
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5914/">http://svn.reviewboard.kde.org/r/5914/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5914/diff/1/?file=41521#file41521line73" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">protected:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">73</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QPoint</span> <span class="n">savedPosToReal</span><span \
class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think \
this should be bore adjustedSavedPos()
toReal looks more converting to a uhm real :)</pre>
</div>
<br />
<p>- Marco</p>
<br />
<p>On November 20th, 2010, 7:34 p.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated 2010-11-20 19:34:11</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently we're saving the notifications using absolute positions, \
because of this the notification is misplaced if the resolution changes, or the \
desktop is extended with another monitor.
This patch changes the way the position is saved, by doing it measuring the space \
between the notification and the screen borders. For example if we place the \
notification 10px from bottom and 10px from right, no matters how the screen \
configuration changes, it will be always placed 10px bottom 10px right.
The only thing left to handle properly is "center" the notification just \
like KRunner does, but that will be another patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tried to misplace the notification by changing the resolution, \
added/removing displays and so far everything has worked well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.h \
<span style="color: grey">(1198889)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.cpp \
<span style="color: grey">(1198889)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5914/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic