--===============0258711594== Content-Type: multipart/alternative; boundary="===============7606723668001005329==" --===============7606723668001005329== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5914/#review8868 ----------------------------------------------------------- /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackd= ialog.h i think this should be bore adjustedSavedPos() = toReal looks more converting to a uhm real :) - Marco On 2010-11-20 19:34:11, Alex Fiestas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5914/ > ----------------------------------------------------------- > = > (Updated 2010-11-20 19:34:11) > = > = > Review request for Plasma and Marco Martin. > = > = > Summary > ------- > = > Currently we're saving the notifications using absolute positions, becaus= e of this the notification is misplaced if the resolution changes, or the d= esktop is extended with another monitor. > = > This patch changes the way the position is saved, by doing it measuring t= he space between the notification and the screen borders. For example if we= place the notification 10px from bottom and 10px from right, no matters ho= w the screen configuration changes, it will be always placed 10px bottom 10= px right. > = > The only thing left to handle properly is "center" the notification just = like KRunner does, but that will be another patch. > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/st= ackdialog.h 1198889 = > /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/st= ackdialog.cpp 1198889 = > = > Diff: http://svn.reviewboard.kde.org/r/5914/diff > = > = > Testing > ------- > = > I tried to misplace the notification by changing the resolution, added/re= moving displays and so far everything has worked well. > = > = > Thanks, > = > Alex > = > --===============7606723668001005329== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5914/

= =

/trunk/KDE/kdebase/workspace/plasma/generic/applets/notificatio= ns/ui/stackdialog.h (Diff revision 1)
protected:
		73	QPoint savedPosToReal() = const;

i think this should be bore adjustedSavedPos()

toReal looks more converting to a uhm real :)

- Marco

On November 20th, 2010, 7:34 p.m., Alex Fiestas wrote:

Review request for Plasma and Marco Martin.

By Alex Fiestas.

Updated 2010-11-20 19:34:11

Descripti= on

Currently we're saving the notifications using absolute =
positions, because of this the notification is misplaced if the resolution =
changes, or the desktop is extended with another monitor.

This patch changes the way the position is saved, by doing it measuring the=
 space between the notification and the screen borders. For example if we p=
lace the notification 10px from bottom and 10px from right, no matters how =
the screen configuration changes, it will be always placed 10px bottom 10px=
 right.

The only thing left to handle properly is "center" the notificati=
on just like KRunner does, but that will be another patch.

Testing <= /h1>

I tried to misplace the notification by changing the resolut=
ion, added/removing displays and so far everything has worked well.

Diffs=

/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/s= tackdialog.h (1198889)
/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/s= tackdialog.cpp (1198889)

--===============7606723668001005329==-- --===============0258711594== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0258711594==--