'Re: Review Request: Added System Wallpaper and My Downloaded Wallpaper'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Added System Wallpaper and My Downloaded Wallpaper
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2010-10-30 22:50:25
Message-ID: 20101030225025.4706.96642 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5705/
-----------------------------------------------------------

(Updated 2010-10-30 22:50:25.298178)

Review request for Plasma and Davide Bettio.

Changes
-------

Fixed the layout and added the curly braces where needed.
Aaron, is the wording of the tooltips ok? or should it change also somehow?

Summary
-------

Prompted by bug https://bugs.kde.org/show_bug.cgi?id=253360 and my own itch at not \
having the ability to easly add ~/.kde/share/wallpaper/ to the slideshow, I added \
these two checkboxes from this wishlist bug.  Let me know if you think the tooltips \
should be reworded I just took an initial stab at them.

Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1190748 
  /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1190748 
  /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui \
1190748 

Diff: http://svn.reviewboard.kde.org/r/5705/diff

Testing
-------

I works quite well actually.  I still think we need to disable the apply and ok \
buttons when no checkbox is checked and no paths are in the listbox, but we work \
around that by putting the system folder in the list if there are no folders in the \
kconfig.

Thanks,

Jeremy

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5705/">http://svn.reviewboard.kde.org/r/5705/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Davide Bettio.</div>
<div>By Jeremy Whiting.</div>

<p style="color: grey;"><i>Updated 2010-10-30 22:50:25.298178</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed the layout and added the curly braces where needed. Aaron, is the \
wording of the tooltips ok? or should it change also somehow?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Prompted by bug https://bugs.kde.org/show_bug.cgi?id=253360 and my own \
itch at not having the ability to easly add ~/.kde/share/wallpaper/ to the slideshow, \
I added these two checkboxes from this wishlist bug.  Let me know if you think the \
tooltips should be reworded I just took an initial stab at them.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I works quite well actually.  I still think we need to disable the apply \
and ok buttons when no checkbox is checked and no paths are in the listbox, but we \
work around that by putting the system folder in the list if there are no folders in \
the kconfig.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h <span \
style="color: grey">(1190748)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp <span \
style="color: grey">(1190748)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui \
<span style="color: grey">(1190748)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5705/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 