'Re: Review Request: Added System Wallpaper and My Downloaded Wallpaper'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Added System Wallpaper and My Downloaded Wallpaper
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-10-29 17:38:36
Message-ID: 20101029173836.771.52617 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5705/#review8425
-----------------------------------------------------------

i like the idea a lot. there are two issues that must be addressed before it can be \
committed, however. 

one is quite trivial: put curly braces around the one liner if statements, kdelibs \
style. e.g.:

the other is almost as trivial: the new checkboxes need the labels fixed. they also \
need to be put into the layout properly like the rest of the widgets: a QLabel on \
right with the text, checkbox (with empty text!) on the right. all the widgets should \
line up from top to bottom along the "center" line of the label<->widget margin.

with those fixes, this can go in. thanks for the patch :)

/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://svn.reviewboard.kde.org/r/5705/#comment8739>

    use braces, even on single line statements.

/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui
<http://svn.reviewboard.kde.org/r/5705/#comment8741>

    should be plural and use sentence capitalization: System wallpaper

/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui
<http://svn.reviewboard.kde.org/r/5705/#comment8740>

    should be plural, and use sentence capitalization: "My downloaded wallpapers"

- Aaron

On 2010-10-28 15:28:16, Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5705/
> -----------------------------------------------------------
> 
> (Updated 2010-10-28 15:28:16)
> 
> 
> Review request for Plasma and Davide Bettio.
> 
> 
> Summary
> -------
> 
> Prompted by bug https://bugs.kde.org/show_bug.cgi?id=253360 and my own itch at not \
> having the ability to easly add ~/.kde/share/wallpaper/ to the slideshow, I added \
> these two checkboxes from this wishlist bug.  Let me know if you think the tooltips \
> should be reworded I just took an initial stab at them. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1190556 
> /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1189844 
> /trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui \
> 1189844  
> Diff: http://svn.reviewboard.kde.org/r/5705/diff
> 
> 
> Testing
> -------
> 
> I works quite well actually.  I still think we need to disable the apply and ok \
> buttons when no checkbox is checked and no paths are in the listbox, but we work \
> around that by putting the system folder in the list if there are no folders in the \
> kconfig. 
> 
> Thanks,
> 
> Jeremy
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5705/">http://svn.reviewboard.kde.org/r/5705/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i like the idea a lot. \
there are two issues that must be addressed before it can be committed, however. 

one is quite trivial: put curly braces around the one liner if statements, kdelibs \
style. e.g.:

the other is almost as trivial: the new checkboxes need the labels fixed. they also \
need to be put into the layout properly like the rest of the widgets: a QLabel on \
right with the text, checkbox (with empty text!) on the right. all the widgets should \
line up from top to bottom along the &quot;center&quot; line of the \
label&lt;-&gt;widget margin.

with those fixes, this can go in. thanks for the patch :)</pre>
 <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/5705/diff/1/?file=40370#file40370line201" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp</a>
  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QWidget* Image::createConfigurationInterface(QWidget* parent)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">201</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">if</span> <span class="p">(</span><span class="n">dir</span> <span \
class="o">==</span> <span class="n">KStandardDirs</span><span \
class="o">::</span><span class="n">installPath</span><span class="p">(</span><span \
class="s">&quot;wallpaper&quot;</span><span class="p">))</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">202</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">m_uiSlideshow</span><span class="p">.</span><span \
class="n">m_systemCheckBox</span><span class="o">-&gt;</span><span \
class="n">setChecked</span><span class="p">(</span><span class="kc">true</span><span \
class="p">);</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">203</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span \
class="n">dir</span> <span class="o">==</span> <span class="n">localPath</span><span \
class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">204</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">m_uiSlideshow</span><span class="p">.</span><span \
class="n">m_downloadedCheckBox</span><span class="o">-&gt;</span><span \
class="n">setChecked</span><span class="p">(</span><span class="kc">true</span><span \
class="p">);</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">205</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">else</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">195</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span \
class="n">m_uiSlideshow</span><span class="p">.</span><span \
class="n">m_dirlist</span><span class="o">-&gt;</span><span \
class="n">addItem</span><span class="p">(</span><span class="n">dir</span><span \
class="p">);</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">206</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">                <span \
class="n">m_uiSlideshow</span><span class="p">.</span><span \
class="n">m_dirlist</span><span class="o">-&gt;</span><span \
class="n">addItem</span><span class="p">(</span><span class="n">dir</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">use braces, \
even on single line statements.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/5705/diff/1/?file=40371#file40371line206" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui</a>
  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">206</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      \
&lt;string&gt;System Wallpaper&lt;/string&gt;</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be \
plural and use sentence capitalization: System wallpaper</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/5705/diff/1/?file=40371#file40371line219" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui</a>
  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">219</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      \
&lt;string&gt;My Downloaded Wallpaper&lt;/string&gt;</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should be \
plural, and use sentence capitalization: &quot;My downloaded wallpapers&quot;</pre> \
</div> <br />

<p>- Aaron</p>

<br />
<p>On October 28th, 2010, 3:28 p.m., Jeremy Whiting wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Davide Bettio.</div>
<div>By Jeremy Whiting.</div>

<p style="color: grey;"><i>Updated 2010-10-28 15:28:16</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Prompted by bug https://bugs.kde.org/show_bug.cgi?id=253360 and my own \
itch at not having the ability to easly add ~/.kde/share/wallpaper/ to the slideshow, \
I added these two checkboxes from this wishlist bug.  Let me know if you think the \
tooltips should be reworded I just took an initial stab at them.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I works quite well actually.  I still think we need to disable the apply \
and ok buttons when no checkbox is checked and no paths are in the listbox, but we \
work around that by putting the system folder in the list if there are no folders in \
the kconfig.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h <span \
style="color: grey">(1190556)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp <span \
style="color: grey">(1189844)</span></li>

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/slideshowconfig.ui \
<span style="color: grey">(1189844)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5705/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 