[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Colour scheme problems after revision 1185467
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2010-10-29 17:21:44
Message-ID: 201010291021.52132.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday, October 24, 2010, Ivan Cukic wrote:
> But, it is not the end of the problems - now the text-boxes in dark themes
> have white text and white background.

this is likely because the exact same palette is being used by all of the 
widgets. previously, the palettes that were being generated from the theme 
were being generated by each widget. duplicated code -> inconsistency.

previously, LineEdit was using the ButtonTextColor for QPalette::Text. now it 
is using TextColor. only SpinBox and LineEdit were doing this: all the other 
widgets set QPalette::Text to TextColor. ugh.

i also noticed when looking at this that some widgets also set ButtonText to 
TextColor as well. i'm not sure that was ever right... let's see what happens 
when it is always set to ButtonText as it logically should be.

i'll commit shortly after compiling and testing.

> I guess the text boxes use the same colour as the labels, so that the
> themes need to be changed?

that would break too many themes that already exist.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]