From kde-panel-devel  Fri Oct 29 17:21:44 2010
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: Fri, 29 Oct 2010 17:21:44 +0000
To: kde-panel-devel
Subject: Re: Colour scheme problems after revision 1185467
Message-Id: <201010291021.52132.aseigo () kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=128837296218530
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1217250068=="

--===============1217250068==
Content-Type: multipart/signed;
  boundary="nextPart2691238.d0oJ6dgg63";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2691238.d0oJ6dgg63
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

On Sunday, October 24, 2010, Ivan Cukic wrote:
> But, it is not the end of the problems - now the text-boxes in dark themes
> have white text and white background.

this is likely because the exact same palette is being used by all of the=20
widgets. previously, the palettes that were being generated from the theme=
=20
were being generated by each widget. duplicated code -> inconsistency.

previously, LineEdit was using the ButtonTextColor for QPalette::Text. now =
it=20
is using TextColor. only SpinBox and LineEdit were doing this: all the othe=
r=20
widgets set QPalette::Text to TextColor. ugh.

i also noticed when looking at this that some widgets also set ButtonText t=
o=20
TextColor as well. i'm not sure that was ever right... let's see what happe=
ns=20
when it is always set to ButtonText as it logically should be.

i'll commit shortly after compiling and testing.

> I guess the text boxes use the same colour as the labels, so that the
> themes need to be changed?

that would break too many themes that already exist.

=2D-=20
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

--nextPart2691238.d0oJ6dgg63
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)

iEYEABECAAYFAkzLAq8ACgkQ1rcusafx20OEmACgr7zN/Wt/+yY3y65lx9uhJEcu
1D4An0tZ5U+53Xfu8nmBOtjcc0hQ8dvB
=RFSE
-----END PGP SIGNATURE-----

--nextPart2691238.d0oJ6dgg63--

--===============1217250068==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============1217250068==--