[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: activity templates
From:       "Chani Armitage" <chanika () gmail ! com>
Date:       2010-10-28 21:35:54
Message-ID: 20101028213554.8207.53232 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5709/#review8417
-----------------------------------------------------------


wait, why did I post this? it's so trivial.. I'll just commit :)

- Chani


On 2010-10-28 21:08:41, Chani Armitage wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5709/
> -----------------------------------------------------------
> =

> (Updated 2010-10-28 21:08:41)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> whee! this turned out to be quite easy, actually. :)
> activity templates work peoprly now - an activity is created, and any con=
tainments the script makes are added to it. it also takes on the name and i=
con from the metadata by default. :) all that's missing is a GHNS button!
> =

> I created one template to demo this - a photos activity. it's not as good=
 as it could be (all plasmoids are in the topleft of screen 0) but it's a s=
tart :)
> =

> =

> Diffs
> -----
> =

>   /dev/null PRE-CREATION =

>   /dev/null PRE-CREATION =

>   trunk/KDE/kdebase/workspace/plasma/desktop/shell/CMakeLists.txt 1188056 =

>   trunk/KDE/kdebase/workspace/plasma/desktop/shell/activitymanager/filter=
bar.cpp 1188056 =

>   trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.h 1188056 =

>   trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1188056 =

>   trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/applaunch=
er/launch.cpp 1188056 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5709/diff
> =

> =

> Testing
> -------
> =

> works fine on single-screen. I don't have a multiscreen setup atm, but I =
expect it won't cause any problems.
> =

> =

> Thanks,
> =

> Chani
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5709/">http://svn.reviewboard.kde.org/r/5709/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">wait, why did I post \
this? it&#39;s so trivial.. I&#39;ll just commit :)</pre>  <br />







<p>- Chani</p>


<br />
<p>On October 28th, 2010, 9:08 p.m., Chani Armitage wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Chani Armitage.</div>


<p style="color: grey;"><i>Updated 2010-10-28 21:08:41</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">whee! this turned out to be quite easy, actually. :) activity templates \
work peoprly now - an activity is created, and any containments the script makes are \
added to it. it also takes on the name and icon from the metadata by default. :) all \
that&#39;s missing is a GHNS button!

I created one template to demo this - a photos activity. it&#39;s not as good as it \
could be (all plasmoids are in the topleft of screen 0) but it&#39;s a start :)</pre> \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works fine on single-screen. I don&#39;t have a multiscreen setup atm, \
but I expect it won&#39;t cause any problems.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/workspace/plasma/desktop/shell/CMakeLists.txt <span \
style="color: grey">(1188056)</span></li>

 <li>trunk/KDE/kdebase/workspace/plasma/desktop/shell/activitymanager/filterbar.cpp \
<span style="color: grey">(1188056)</span></li>

 <li>trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.h <span style="color: \
grey">(1188056)</span></li>

 <li>trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp <span \
style="color: grey">(1188056)</span></li>

 <li>trunk/KDE/kdebase/workspace/plasma/generic/containmentactions/applauncher/launch.cpp \
<span style="color: grey">(1188056)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5709/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic