[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: activities dataengine
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2010-10-28 21:11:48
Message-ID: 20101028211148.7699.26082 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-28 18:45:00, Albert Astals Cid wrote:
> > Which of the strings you add here will be shown to the user?
> =
> Chani Armitage wrote:
> none... unless some plasmoid decides to dump the raw data straight to=
widgets (which would be dumb in this case) or they're using plasmaengineex=
plorer (in which case they're a developer and probably want to know the lit=
eral strings).
> =
> so maybe I shouldn't have messages.sh after all?
If not message is ever going to be shown to the user, no you don't need a m=
essages.sh
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5707/#review8414
-----------------------------------------------------------
On 2010-10-28 17:09:34, Chani Armitage wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5707/
> -----------------------------------------------------------
> =
> (Updated 2010-10-28 17:09:34)
> =
> =
> Review request for Plasma and Albert Astals Cid.
> =
> =
> Summary
> -------
> =
> this is a basic activities dataengine. no frills to start with, just a so=
urce for each activity.
> the service allows setting the current activity (other features, like set=
ting an activity's name, can be added later).
> it uses KActivityController and friends internally.
> =
> I'm not sure if I got the i18n right, though - I can't remember how that =
works for dataengines.
> =
> =
> Diffs
> -----
> =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> /dev/null PRE-CREATION =
> trunk/KDE/kdebase/workspace/plasma/generic/applets/activitybar/activity=
bar.h 1188056 =
> trunk/KDE/kdebase/workspace/plasma/generic/applets/activitybar/activity=
bar.cpp 1188056 =
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt 1=
188056 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5707/diff
> =
> =
> Testing
> -------
> =
> I've updated the ActivityBar plasmoid to use the engine, and it works wit=
h no regressions :)
> =
> =
> Thanks,
> =
> Chani
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5707/">http://svn.reviewboard.kde.org/r/5707/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 28th, 2010, 6:45 p.m., <b>Albert Astals \
Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Which of the strings you add here will be shown to the user?</pre> \
</blockquote>
<p>On October 28th, 2010, 8:52 p.m., <b>Chani Armitage</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">none... unless some \
plasmoid decides to dump the raw data straight to widgets (which would be dumb in \
this case) or they're using plasmaengineexplorer (in which case they're a \
developer and probably want to know the literal strings).
so maybe I shouldn't have messages.sh after all?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If not message is ever \
going to be shown to the user, no you don't need a messages.sh</pre> <br />
<p>- Albert</p>
<br />
<p>On October 28th, 2010, 5:09 p.m., Chani Armitage wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Albert Astals Cid.</div>
<div>By Chani Armitage.</div>
<p style="color: grey;"><i>Updated 2010-10-28 17:09:34</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this is a basic activities dataengine. no frills to start with, just a \
source for each activity. the service allows setting the current activity (other \
features, like setting an activity's name, can be added later). it uses \
KActivityController and friends internally.
I'm not sure if I got the i18n right, though - I can't remember how that \
works for dataengines.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've updated the ActivityBar plasmoid to use the engine, and it \
works with no regressions :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>/dev/null <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/applets/activitybar/activitybar.h \
<span style="color: grey">(1188056)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/applets/activitybar/activitybar.cpp \
<span style="color: grey">(1188056)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt <span \
style="color: grey">(1188056)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5707/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic