[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Microblog: small patch so that microblog
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-10-26 8:46:41
Message-ID: 20101026084641.23295.1754 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-21 15:39:47, Marco Martin wrote:
> > for me is okay, even if an obscured password directly in the config file isn't \
> > great... some time ago it did already this thing, why was it removed?
>
> Chani Armitage wrote:
> good question. Mohit, you should look in the svn log and see if there was a reason \
> it was removed... but since it was still *writing* it and just not reading it, my \
> guess would be that someone wasn't paying attention and removed it accidentally.
> Mohit Kothari wrote:
> I went through the log, and it seems that although password was being written to \
> config file but *never* ever read from it.
> The functionality was *never* implemented nor removed accidentally.
>
> Mohit Kothari wrote:
> Sorry, i published the last comment instead of discarding it.... the thing is that \
> in configChanged() the password is stored in temporary variable while to check \
> whether to read or write the password its checked on global variable m_password \
> which is empty. hence we get the empty password string whenever we deny the wallet. \
>
>
ok, i've committed the patch
you can close the request ;)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5679/#review8290
-----------------------------------------------------------
On 2010-10-21 18:19:51, Mohit Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5679/
> -----------------------------------------------------------
>
> (Updated 2010-10-21 18:19:51)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> It was a bug posted on bugs.kde.org,
> Here is the link: https://bugs.kde.org/show_bug.cgi?id=242377
> Well it did stored the password in config file but never read it.
> So i just added the reading feature and reloaded the history.
>
>
> Diffs
> -----
>
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp \
> 1188219
> Diff: http://svn.reviewboard.kde.org/r/5679/diff
>
>
> Testing
> -------
>
> I tested it on kdeplasma-addons revision 1187571
>
>
> Thanks,
>
> Mohit
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5679/">http://svn.reviewboard.kde.org/r/5679/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 21st, 2010, 3:39 p.m., <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">for me is okay, even if an obscured password directly in the config file \
isn't great... some time ago it did already this thing, why was it removed?</pre>
</blockquote>
<p>On October 25th, 2010, 5:45 p.m., <b>Chani Armitage</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">good question. Mohit, \
you should look in the svn log and see if there was a reason it was removed... but \
since it was still *writing* it and just not reading it, my guess would be that \
someone wasn't paying attention and removed it accidentally.</pre> </blockquote>
<p>On October 26th, 2010, 8:22 a.m., <b>Mohit Kothari</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I went through the log, \
and it seems that although password was being written to config file but *never* ever \
read from it.
The functionality was *never* implemented nor removed accidentally.</pre>
</blockquote>
<p>On October 26th, 2010, 8:36 a.m., <b>Mohit Kothari</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, i published the \
last comment instead of discarding it.... the thing is that in configChanged() the \
password is stored in temporary variable while to check whether to read or write the \
password its checked on global variable m_password which is empty. hence we get the \
empty password string whenever we deny the wallet.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, i've committed \
the patch you can close the request ;)</pre>
<br />
<p>- Marco</p>
<br />
<p>On October 21st, 2010, 6:19 p.m., Mohit Kothari wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Mohit Kothari.</div>
<p style="color: grey;"><i>Updated 2010-10-21 18:19:51</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It was a bug posted on bugs.kde.org, Here is the link: \
https://bugs.kde.org/show_bug.cgi?id=242377 Well it did stored the password in config \
file but never read it. So i just added the reading feature and reloaded the \
history.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested it on kdeplasma-addons revision 1187571</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp \
<span style="color: grey">(1188219)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5679/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic