--===============2111450021== Content-Type: multipart/alternative; boundary="===============4528266045255638194==" --===============4528266045255638194== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-10-21 15:39:47, Marco Martin wrote: > > for me is okay, even if an obscured password directly in the config fil= e isn't great... > > some time ago it did already this thing, why was it removed? > = > Chani Armitage wrote: > good question. Mohit, you should look in the svn log and see if there= was a reason it was removed... > but since it was still *writing* it and just not reading it, my guess= would be that someone wasn't paying attention and removed it accidentally. > = > Mohit Kothari wrote: > I went through the log, and it seems that although password was being= written to config file but *never* ever read from it. > = > The functionality was *never* implemented nor removed accidentally. > = > Mohit Kothari wrote: > Sorry, i published the last comment instead of discarding it.... the = thing is that in configChanged() the password is stored in temporary variab= le while to check whether to read or write the password its checked on glob= al variable m_password which is empty. hence we get the empty password stri= ng whenever we deny the wallet. > = > = > ok, i've committed the patch you can close the request ;) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5679/#review8290 ----------------------------------------------------------- On 2010-10-21 18:19:51, Mohit Kothari wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5679/ > ----------------------------------------------------------- > = > (Updated 2010-10-21 18:19:51) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > It was a bug posted on bugs.kde.org, > Here is the link: https://bugs.kde.org/show_bug.cgi?id=3D242377 > Well it did stored the password in config file but never read it. > So i just added the reading feature and reloaded the history. > = > = > Diffs > ----- > = > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/micro= blog/microblog.cpp 1188219 = > = > Diff: http://svn.reviewboard.kde.org/r/5679/diff > = > = > Testing > ------- > = > I tested it on kdeplasma-addons revision 1187571 > = > = > Thanks, > = > Mohit > = > --===============4528266045255638194== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5679/

On October 21st, 2010, 3:39 p.m., Marco Mar= tin wrote:

for me is=
 okay, even if an obscured password directly in the config file isn't g=
reat...
some time ago it did already this thing, why was it removed?

On October 25th, 2010, 5:45 p.m., Chani Armitage wrote:

good ques=
tion. Mohit, you should look in the svn log and see if there was a reason i=
t was removed...
but since it was still *writing* it and just not reading it, my guess would=
 be that someone wasn't paying attention and removed it accidentally.

On October 26th, 2010, 8:22 a.m., Mohit Kothari wrote:

I went th=
rough the log, and it seems that although password was being written to con=
fig file but *never* ever read from it.

The functionality was *never* implemented nor removed accidentally.

On October 26th, 2010, 8:36 a.m., Mohit Kothari wrote:

Sorry, i =
published the last comment instead of discarding it.... the thing is that i=
n configChanged() the password is stored in temporary variable while to che=
ck whether to read or write the password its checked on global variable m_p=
assword which is empty. hence we get the empty password string whenever we =
deny the wallet.

ok, i'v=
e committed the patch
you can close the request ;)

- Marco

On October 21st, 2010, 6:19 p.m., Mohit Kothari wrote:

Review request for Plasma.

By Mohit Kothari.

Updated 2010-10-21 18:19:51

Descripti= on

It was a bug posted on bugs.kde.org,
Here is the link: https://bugs.kde.org/show_bug.cgi?id=3D242377
Well it did stored the password in config file but never read it.
So i just added the reading feature and reloaded the history.

Testing <= /h1>

I tested it on kdeplasma-addons revision 1187571

Diffs=

svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/micr= oblog/microblog.cpp (1188219)

--===============4528266045255638194==-- --===============2111450021== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2111450021==--