[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasma::Svg: Do not require exact match for size
From: "Manuel Mommertz" <2kmm () gmx ! de>
Date: 2010-10-25 18:36:05
Message-ID: 20101025183605.29241.41320 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5689/#review8346
-----------------------------------------------------------
Ship it!
Ok, the performance should be acceptable and the patch looks good to me. I am fine \
with commiting but please wait for a go from a bigger plasma dev. ;)
/trunk/KDE/kdelibs/plasma/svg.cpp
<http://svn.reviewboard.kde.org/r/5689/#comment8625>
A bit shorter but not exact the same:
"id\\s*=\\s*(['\"])(\\d+)-(\\d+)-([^'\"]+)\\1"
If you know a solution to express [^\1] this would be nice, but I think this \
isn't possible.
Whatever this solution should be enaugh for plasma.
- Manuel
On 2010-10-25 15:29:32, Ingomar Wesp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5689/
> -----------------------------------------------------------
>
> (Updated 2010-10-25 15:29:32)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Previously, if an SVG contained size hinted elements, they were only used when the \
> display size matched the size hint exactly. This patch tries to relax this \
> condition by searching for the smallest size hinted element that is still bigger \
> than the display size (in order for the element to be chosen, it also has to have \
> the same aspect ratio). If no such element can be found, it falls back to the \
> normal element id as passed.
> In order to speed up the lookup (and because it appears to be impossible to access \
> the DOM of an already loaded SvgRenderer), all size hinted element ids are stored \
> in SharedSvgRenderer at load time.
> I think it would be good to change the QRegExp based id fetching into a proper DOM \
> traversal. Are there any convenience functions in KDELibs that allow easy iterating \
> over all elements (couldn't find any) or do I have to implement that myself based \
> on Qt's DOM classes?
> Please tell me what you think... Have I missed something?
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/plasma/private/svg_p.h 1189690
> /trunk/KDE/kdelibs/plasma/svg.cpp 1189690
>
> Diff: http://svn.reviewboard.kde.org/r/5689/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ingomar
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5689/">http://svn.reviewboard.kde.org/r/5689/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, the performance \
should be acceptable and the patch looks good to me. I am fine with commiting but \
please wait for a go from a bigger plasma dev. ;)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5689/diff/3/?file=40220#file40220line81" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/KDE/kdelibs/plasma/svg.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">SharedSvgRenderer::SharedSvgRenderer(const QByteArray &contents, const QString \
&styleSheet, QObject *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">81</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"id</span><span class="se">\\</span><span \
class="s">s*=</span><span class="se">\\</span><span class="s">s*('(</span><span \
class="se">\\</span><span class="s">d+)-(</span><span class="se">\\</span><span \
class="s">d+)-([^']+)')|(</span><span class="se">\"</span><span \
class="s">(</span><span class="se">\\</span><span class="s">d+)-(</span><span \
class="se">\\</span><span class="s">d+)-([^</span><span \
class="se">\"</span><span class="s">]+)</span><span \
class="se">\"</span><span class="s">)"</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A bit \
shorter but not exact the same: \
"id\\s*=\\s*(['\"])(\\d+)-(\\d+)-([^'\"]+)\\1"
If you know a solution to express [^\1] this would be nice, but I think this \
isn't possible.
Whatever this solution should be enaugh for plasma.</pre>
</div>
<br />
<p>- Manuel</p>
<br />
<p>On October 25th, 2010, 3:29 p.m., Ingomar Wesp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ingomar Wesp.</div>
<p style="color: grey;"><i>Updated 2010-10-25 15:29:32</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Previously, if an SVG contained size hinted elements, they were only \
used when the display size matched the size hint exactly. This patch tries to relax \
this condition by searching for the smallest size hinted element that is still bigger \
than the display size (in order for the element to be chosen, it also has to have the \
same aspect ratio). If no such element can be found, it falls back to the normal \
element id as passed.
In order to speed up the lookup (and because it appears to be impossible to access \
the DOM of an already loaded SvgRenderer), all size hinted element ids are stored in \
SharedSvgRenderer at load time.
I think it would be good to change the QRegExp based id fetching into a proper DOM \
traversal. Are there any convenience functions in KDELibs that allow easy iterating \
over all elements (couldn't find any) or do I have to implement that myself based \
on Qt's DOM classes?
Please tell me what you think... Have I missed something?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/plasma/private/svg_p.h <span style="color: \
grey">(1189690)</span></li>
<li>/trunk/KDE/kdelibs/plasma/svg.cpp <span style="color: \
grey">(1189690)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5689/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic