'Re: Review Request: Plasma::Svg: Do not require exact match for size'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasma::Svg: Do not require exact match for size
From:       "Ingomar Wesp" <ingomar () wesp ! name>
Date:       2010-10-25 15:29:32
Message-ID: 20101025152932.24742.67790 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5689/
-----------------------------------------------------------

(Updated 2010-10-25 15:29:32.167235)

Review request for Plasma.

Summary
-------

Previously, if an SVG contained size hinted elements, they were only used w=
hen the display size matched the size hint exactly. This patch tries to rel=
ax this condition by searching for the smallest size hinted element that is=
 still bigger than the display size (in order for the element to be chosen,=
 it also has to have the same aspect ratio). If no such element can be foun=
d, it falls back to the normal element id as passed.

In order to speed up the lookup (and because it appears to be impossible to=
 access the DOM of an already loaded SvgRenderer), all size hinted element =
ids are stored in SharedSvgRenderer at load time.

I think it would be good to change the QRegExp based id fetching into a pro=
per DOM traversal. Are there any convenience functions in KDELibs that allo=
w easy iterating over all elements (couldn't find any) or do I have to impl=
ement that myself based on Qt's DOM classes?

Please tell me what you think... Have I missed something?

Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/private/svg_p.h 1189690 =

  /trunk/KDE/kdelibs/plasma/svg.cpp 1189690 =

Diff: http://svn.reviewboard.kde.org/r/5689/diff

Testing
-------

Thanks,

Ingomar

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5689/">http://svn.reviewboard.kde.org/r/5689/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Ingomar Wesp.</div>

<p style="color: grey;"><i>Updated 2010-10-25 15:29:32.167235</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Previously, if an SVG contained size hinted elements, they were only \
used when the display size matched the size hint exactly. This patch tries to relax \
this condition by searching for the smallest size hinted element that is still bigger \
than the display size (in order for the element to be chosen, it also has to have the \
same aspect ratio). If no such element can be found, it falls back to the normal \
element id as passed.

In order to speed up the lookup (and because it appears to be impossible to access \
the DOM of an already loaded SvgRenderer), all size hinted element ids are stored in \
SharedSvgRenderer at load time.

I think it would be good to change the QRegExp based id fetching into a proper DOM \
traversal. Are there any convenience functions in KDELibs that allow easy iterating \
over all elements (couldn&#39;t find any) or do I have to implement that myself based \
on Qt&#39;s DOM classes?

Please tell me what you think... Have I missed something?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdelibs/plasma/private/svg_p.h <span style="color: \
grey">(1189690)</span></li>

 <li>/trunk/KDE/kdelibs/plasma/svg.cpp <span style="color: \
grey">(1189690)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5689/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 