'Review Request: System Tray: Use unhider arrows from arrows.svg'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: System Tray: Use unhider arrows from arrows.svg
From:       "Ingomar Wesp" <ingomar () wesp ! name>
Date:       2010-10-13 14:01:12
Message-ID: 20101013140112.13003.91469 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5618/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

As discussed on plasma-devel (http://thread.gmane.org/gmane.comp.kde.devel.=
plasma/13257), this patch changes the systray applet's extender arrow to us=
e the SVG elements from ${theme}/widgets/arrows.svgz instead of the ones fr=
om ${theme}/widgets/systemtray.svgz. This would allow other applets to use =
the same arrow symbols when they want to provide similar functionality.

For this not to break the current look, the arrows from systemtray.svgz wou=
ld have to be moved to arrows.svgz as size-hinted versions of the arrows th=
at are already there.

Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskare=
a.cpp 1183142 =

Diff: http://svn.reviewboard.kde.org/r/5618/diff

Testing
-------

Thanks,

Ingomar

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5618/">http://svn.reviewboard.kde.org/r/5618/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Ingomar Wesp.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed on plasma-devel \
(http://thread.gmane.org/gmane.comp.kde.devel.plasma/13257), this patch changes the \
systray applet&#39;s extender arrow to use the SVG elements from \
${theme}/widgets/arrows.svgz instead of the ones from \
${theme}/widgets/systemtray.svgz. This would allow other applets to use the same \
arrow symbols when they want to provide similar functionality.

For this not to break the current look, the arrows from systemtray.svgz would have to \
be moved to arrows.svgz as size-hinted versions of the arrows that are already \
there.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp \
<span style="color: grey">(1183142)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5618/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 