'Review Request: More improvements to the Fifteen puzzle'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: More improvements to the Fifteen puzzle
From:       "Anthony Bryant" <antjbryant () gmail ! com>
Date:       2010-10-13 13:40:37
Message-ID: 20101013134037.12307.69303 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5617/
-----------------------------------------------------------

Review request for Plasma.

Summary
-------

Lots more improvements to the fifteen puzzle:
* Improved shuffle algorithm
* Resize fonts when the board size is changed
* Better checking for whether the board is solved
* Stop the pieces flickering when they are moved
* Changed the way board positions are stored
* Animate in the blank piece when the puzzle is solved
* Add a status bar underneath the puzzle, which shows a shuffle button and the time elapsed

This addresses bug 156648.
    https://bugs.kde.org/show_bug.cgi?id=156648

Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1185297 
  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1185297 
  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h 1185297 
  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp 1185297 
  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1185297 
  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1185297 

Diff: http://svn.reviewboard.kde.org/r/5617/diff

Testing
-------

Solved the puzzle a few times, changed some settings, resized the applet.

Screenshots
-----------

new puzzle layout
  http://svn.reviewboard.kde.org/r/5617/s/535/

Thanks,

Anthony

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5617/">http://svn.reviewboard.kde.org/r/5617/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Anthony Bryant.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Lots more improvements to the fifteen puzzle:
* Improved shuffle algorithm
* Resize fonts when the board size is changed
* Better checking for whether the board is solved
* Stop the pieces flickering when they are moved
* Changed the way board positions are stored
* Animate in the blank piece when the puzzle is solved
* Add a status bar underneath the puzzle, which shows a shuffle button and the time \
elapsed</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Solved the puzzle a few times, changed some settings, resized the \
applet.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=156648">156648</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h <span \
style="color: grey">(1185297)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp <span \
style="color: grey">(1185297)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.h <span \
style="color: grey">(1185297)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp <span \
style="color: grey">(1185297)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h <span \
style="color: grey">(1185297)</span></li>

 <li>/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp <span \
style="color: grey">(1185297)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5617/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://svn.reviewboard.kde.org/r/5617/s/535/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/10/13/fifteen-puzzle_400x100.png" \
style="border: 1px black solid;" alt="new puzzle layout" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 