[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add city and country resolution to GPS
From: "John Layt" <johnlayt () googlemail ! com>
Date: 2010-09-25 14:02:48
Message-ID: 20100925140248.30073.88900 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2009-04-14 18:59:59, Aaron Seigo wrote:
> > other than a couple of code style comments, and that i can't test it wi=
th a gps for you either :/, my only question/concern is that it's doing loo=
k ups on the internet without checking to see if we're connected. it could =
be in a local cache, but i'm going to guess that in a fairly typical "i'm u=
sing gps" scenario one won't have an internet connection as well. should we=
query solid for network status?
> > =
> > rambling off-topic here: i also wonder if we aren't going to want some =
"can use the internet for ..." settings somewhere for the case where we hav=
e a system with gps, cheap wifi and expensive g3 connectivity .. somethings=
, like looking up the place name on the internet, may not be acceptible eve=
n if there is g3 service? not a use case we actually have to deal with now,=
but it's something that pops into my head every once in a while .. .. like=
when i see a patch like this :)
> =
> Petri Damst=C3=A9n wrote:
> Dataengine already checks network state but since it thinks gps does =
not need one it uses gps plugin. I think location -> place should be a sepa=
rate plugin. It's not possible with current code though and I would like to=
evaluate all the other possibilities before doing rewrite (there were some=
wlan etc ideas as well). For 4.3 should it go like this, I'm not sure?
> =
> For 4.4 is geoclue out of the question? It seems that we are implemen=
ting pretty much all the same things.
>
> =
> Beat Wolf wrote:
> any progress on this patch?
> =
> Beat Wolf wrote:
> can this patch be asumed dead?
I do have a GPS, I could try get it working to test the patch if there is s=
till interest in getting this in. However, we really need to sort out geol=
ocation services for KDE as a whole, re-inventing everything that Geoclue a=
nd Marble have already figured out is not the best use of resources.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/592/#review923
-----------------------------------------------------------
On 2009-04-14 16:46:26, Andrew Coles wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/592/
> -----------------------------------------------------------
> =
> (Updated 2009-04-14 16:46:26)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> Yesterday, I proposed a patch for using an IP geolocation service that re=
turns longitude and latitude, as the GPS backend would give that data but t=
he IP one would not. Today, it's the other way around: a patch to add plac=
e name and country information to the GPS geolocation data, as the IP geolo=
cation gives this but GPS geolocation does not.
> =
> The only caveat is that I'm programming blind - I don't have a GPS receiv=
er, and 'it compiles' is far from good enough. Hence, I need a volunteer t=
o test it - anyone?
> =
> Assuming it works, the geolocation data engine will then have reached the=
point where the fields returned are identical, /irregardless of whether IP=
or GPS data is used/. Specifically, the user gets:
> =
> - Latitude
> - Longitude
> - Accuracy
> - Country Name
> - Country Code
> - City Name
> =
> =
> Diffs
> -----
> =
> /trunk/kdereview/plasma/dataengines/geolocation/location_gps.h 954031 =
> /trunk/kdereview/plasma/dataengines/geolocation/location_gps.cpp 954031 =
> =
> Diff: http://svn.reviewboard.kde.org/r/592/diff
> =
> =
> Testing
> -------
> =
> It compiles, and it looks alright. How pitiful is that? Given it's base=
d on the IP geolocation XML code, but using a reverse geocoding rather than=
IP geolocation service, it should in theory work, but it really does need =
testing by someone with a GPS unit.
> =
> =
> Thanks,
> =
> Andrew
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/592/">http://svn.reviewboard.kde.org/r/592/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 14th, 2009, 6:59 p.m., <b>Aaron Seigo</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">other than \
a couple of code style comments, and that i can't test it with a gps for you \
either :/, my only question/concern is that it's doing look ups on the internet \
without checking to see if we're connected. it could be in a local cache, but \
i'm going to guess that in a fairly typical "i'm using gps" \
scenario one won't have an internet connection as well. should we query solid for \
network status?
rambling off-topic here: i also wonder if we aren't going to want some "can \
use the internet for ..." settings somewhere for the case where we have a system \
with gps, cheap wifi and expensive g3 connectivity .. somethings, like looking up the \
place name on the internet, may not be acceptible even if there is g3 service? not a \
use case we actually have to deal with now, but it's something that pops into my \
head every once in a while .. .. like when i see a patch like this :)</pre> \
</blockquote>
<p>On April 15th, 2009, 1:47 a.m., <b>Petri Damstén</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dataengine already \
checks network state but since it thinks gps does not need one it uses gps plugin. I \
think location -> place should be a separate plugin. It's not possible with \
current code though and I would like to evaluate all the other possibilities before \
doing rewrite (there were some wlan etc ideas as well). For 4.3 should it go like \
this, I'm not sure?
For 4.4 is geoclue out of the question? It seems that we are implementing pretty much \
all the same things. </pre>
</blockquote>
<p>On January 24th, 2010, 3:18 p.m., <b>Beat Wolf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">any progress on this \
patch?</pre> </blockquote>
<p>On September 24th, 2010, 10:22 a.m., <b>Beat Wolf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">can this patch be asumed \
dead?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do have a GPS, I could \
try get it working to test the patch if there is still interest in getting this in. \
However, we really need to sort out geolocation services for KDE as a whole, \
re-inventing everything that Geoclue and Marble have already figured out is not the \
best use of resources.</pre> <br />
<p>- John</p>
<br />
<p>On April 14th, 2009, 4:46 p.m., Andrew Coles wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andrew Coles.</div>
<p style="color: grey;"><i>Updated 2009-04-14 16:46:26</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yesterday, I proposed a patch for using an IP geolocation service that \
returns longitude and latitude, as the GPS backend would give that data but the IP \
one would not. Today, it's the other way around: a patch to add place name and \
country information to the GPS geolocation data, as the IP geolocation gives this but \
GPS geolocation does not.
The only caveat is that I'm programming blind - I don't have a GPS receiver, \
and 'it compiles' is far from good enough. Hence, I need a volunteer to test \
it - anyone?
Assuming it works, the geolocation data engine will then have reached the point where \
the fields returned are identical, /irregardless of whether IP or GPS data is used/. \
Specifically, the user gets:
- Latitude
- Longitude
- Accuracy
- Country Name
- Country Code
- City Name</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles, and it looks alright. How pitiful is that? Given it's \
based on the IP geolocation XML code, but using a reverse geocoding rather than IP \
geolocation service, it should in theory work, but it really does need testing by \
someone with a GPS unit.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdereview/plasma/dataengines/geolocation/location_gps.h <span \
style="color: grey">(954031)</span></li>
<li>/trunk/kdereview/plasma/dataengines/geolocation/location_gps.cpp <span \
style="color: grey">(954031)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/592/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic