This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/592/ |
On April 14th, 2009, 6:59 p.m., Aaron Seigo wrote:
other than a couple of code style comments, and that i can't test it with a gps for you either :/, my only question/concern is that it's doing look ups on the internet without checking to see if we're connected. it could be in a local cache, but i'm going to guess that in a fairly typical "i'm using gps" scenario one won't have an internet connection as well. should we query solid for network status? rambling off-topic here: i also wonder if we aren't going to want some "can use the internet for ..." settings somewhere for the case where we have a system with gps, cheap wifi and expensive g3 connectivity .. somethings, like looking up the place name on the internet, may not be acceptible even if there is g3 service? not a use case we actually have to deal with now, but it's something that pops into my head every once in a while .. .. like when i see a patch like this :)On April 15th, 2009, 1:47 a.m., Petri Damstén wrote:
Dataengine already checks network state but since it thinks gps does not need one it uses gps plugin. I think location -> place should be a separate plugin. It's not possible with current code though and I would like to evaluate all the other possibilities before doing rewrite (there were some wlan etc ideas as well). For 4.3 should it go like this, I'm not sure? For 4.4 is geoclue out of the question? It seems that we are implementing pretty much all the same things.On January 24th, 2010, 3:18 p.m., Beat Wolf wrote:
any progress on this patch?On September 24th, 2010, 10:22 a.m., Beat Wolf wrote:
can this patch be asumed dead?
I do have a GPS, I could try get it working to test the patch if there is still interest in getting this in. However, we really need to sort out geolocation services for KDE as a whole, re-inventing everything that Geoclue and Marble have already figured out is not the best use of resources.
- John
On April 14th, 2009, 4:46 p.m., Andrew Coles wrote:
Review request for Plasma.
By Andrew Coles.
Updated 2009-04-14 16:46:26 Description
Testing
Diffs
|