[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The
From: "Beat Wolf" <asraniel () fryx ! ch>
Date: 2010-09-24 10:32:02
Message-ID: 20100924103202.1496.39887 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4119/#review7748
-----------------------------------------------------------
can somebody resume what the results of the discussion where?
- Beat
On 2010-05-23 22:52:04, Ignat Semenov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4119/
> -----------------------------------------------------------
> =
> (Updated 2010-05-23 22:52:04)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> This is the final version of the Pager configuration Dialog patch. Change=
s:
> =
> - Brought back radiobuttons
> - Changed the "Display icons" checkbox to respect KDE style
> - Introduced a ton of layouts and set a top-level layout so that the dial=
og scales properly now
> - Centered the "Configure Desktops" button and made it huge
> =
> I plan to fix the layout issues for all plasmoid configuration dialogs, a=
s time allows.
> Now I'd like to know what's the rationale behind headers in configuration=
dialogs. They're redundant from my point of view as they duplicate the inf=
ormation which is on the left in the list of configuration pages. Maybe the=
y can be removed? Not it Plasma, of course, but in KConfigurationDialog sou=
rce.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp 112=
9710 =
> /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pagerConfig.u=
i 1129710 =
> =
> Diff: http://svn.reviewboard.kde.org/r/4119/diff
> =
> =
> Testing
> -------
> =
> Built it and it really scales properly now. There is only a minor problem=
with Oxygen style and I've already filed a bug against Oxygen.
> =
> =
> Screenshots
> -----------
> =
> New configuration dialog
> http://svn.reviewboard.kde.org/r/4119/s/410/
> =
> =
> Thanks,
> =
> Ignat
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/4119/">http://svn.reviewboard.kde.org/r/4119/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">can somebody resume what \
the results of the discussion where?</pre> <br />
<p>- Beat</p>
<br />
<p>On May 23rd, 2010, 10:52 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated 2010-05-23 22:52:04</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the final version of the Pager configuration Dialog patch. \
Changes:
- Brought back radiobuttons
- Changed the "Display icons" checkbox to respect KDE style
- Introduced a ton of layouts and set a top-level layout so that the dialog scales \
properly now
- Centered the "Configure Desktops" button and made it huge
I plan to fix the layout issues for all plasmoid configuration dialogs, as time \
allows. Now I'd like to know what's the rationale behind headers in \
configuration dialogs. They're redundant from my point of view as they duplicate \
the information which is on the left in the list of configuration pages. Maybe they \
can be removed? Not it Plasma, of course, but in KConfigurationDialog source.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built it and it really scales properly now. There is only a minor \
problem with Oxygen style and I've already filed a bug against Oxygen.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp <span \
style="color: grey">(1129710)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pagerConfig.ui <span \
style="color: grey">(1129710)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/4119/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/4119/s/410/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/05/23/snapshot1_400x100.png" \
style="border: 1px black solid;" alt="New configuration dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic