--===============1361008239== Content-Type: multipart/alternative; boundary="===============7743060000012325235==" --===============7743060000012325235== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4119/#review7748 ----------------------------------------------------------- can somebody resume what the results of the discussion where? - Beat On 2010-05-23 22:52:04, Ignat Semenov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4119/ > ----------------------------------------------------------- > = > (Updated 2010-05-23 22:52:04) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > This is the final version of the Pager configuration Dialog patch. Change= s: > = > - Brought back radiobuttons > - Changed the "Display icons" checkbox to respect KDE style > - Introduced a ton of layouts and set a top-level layout so that the dial= og scales properly now > - Centered the "Configure Desktops" button and made it huge > = > I plan to fix the layout issues for all plasmoid configuration dialogs, a= s time allows. > Now I'd like to know what's the rationale behind headers in configuration= dialogs. They're redundant from my point of view as they duplicate the inf= ormation which is on the left in the list of configuration pages. Maybe the= y can be removed? Not it Plasma, of course, but in KConfigurationDialog sou= rce. > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp 112= 9710 = > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pagerConfig.u= i 1129710 = > = > Diff: http://svn.reviewboard.kde.org/r/4119/diff > = > = > Testing > ------- > = > Built it and it really scales properly now. There is only a minor problem= with Oxygen style and I've already filed a bug against Oxygen. > = > = > Screenshots > ----------- > = > New configuration dialog > http://svn.reviewboard.kde.org/r/4119/s/410/ > = > = > Thanks, > = > Ignat > = > --===============7743060000012325235== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/4119/

can somebo=
dy resume what the results of the discussion where?

- Beat

On May 23rd, 2010, 10:52 p.m., Ignat Semenov wrote:

Review request for Plasma.

By Ignat Semenov.

Updated 2010-05-23 22:52:04

Descripti= on

This is the final version of the Pager configuration Dialog =
patch. Changes:

- Brought back radiobuttons
- Changed the "Display icons" checkbox to respect KDE style
- Introduced a ton of layouts and set a top-level layout so that the dialog=
 scales properly now
- Centered the "Configure Desktops" button and made it huge

I plan to fix the layout issues for all plasmoid configuration dialogs, as =
time allows.
Now I'd like to know what's the rationale behind headers in configu=
ration dialogs. They're redundant from my point of view as they duplica=
te the information which is on the left in the list of configuration pages.=
 Maybe they can be removed? Not it Plasma, of course, but in KConfiguration=
Dialog source.

Testing <= /h1>

Built it and it really scales properly now. There is only a =
minor problem with Oxygen style and I've already filed a bug against Ox=
ygen.

Diffs=

/trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp (1129710)
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pagerConfig.= ui (1129710)

Screensho= ts

3D"New

--===============7743060000012325235==-- --===============1361008239== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1361008239==--