[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Routing (un)mounting error notifications via
From: "Beat Wolf" <asraniel () fryx ! ch>
Date: 2010-09-24 10:23:50
Message-ID: 20100924102350.1263.80169 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3896/#review7743
-----------------------------------------------------------
please mark this patch as submitted.
- Beat
On 2010-05-05 16:10:45, Jacopo De Simoi wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3896/
> -----------------------------------------------------------
> =
> (Updated 2010-05-05 16:10:45)
> =
> =
> Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart.
> =
> =
> Summary
> -------
> =
> This patch provides a dataengine which collects and exposes (un)mounting =
error notifications; the plasma devicenotifier will spawn an instance of th=
is dataengine to tell knotify that it will display such notifications itsel=
f. =
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt 1=
123205 =
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotificati=
ons/CMakeLists.txt PRE-CREATION =
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotificati=
ons/devicenotificationsengine.h PRE-CREATION =
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotificati=
ons/devicenotificationsengine.cpp PRE-CREATION =
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotificati=
ons/org.kde.DeviceNotifications.xml PRE-CREATION =
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotificati=
ons/plasma-dataengine-devicenotifications.desktop PRE-CREATION =
> =
> Diff: http://svn.reviewboard.kde.org/r/3896/diff
> =
> =
> Testing
> -------
> =
> This patch depends on the corresponding one for knotify;
> =
> With that patch it works as expected.
> =
> =
> Thanks,
> =
> Jacopo
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/3896/">http://svn.reviewboard.kde.org/r/3896/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please mark this patch \
as submitted.</pre> <br />
<p>- Beat</p>
<br />
<p>On May 5th, 2010, 4:10 p.m., Jacopo De Simoi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart.</div>
<div>By Jacopo De Simoi.</div>
<p style="color: grey;"><i>Updated 2010-05-05 16:10:45</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch provides a dataengine which collects and exposes (un)mounting \
error notifications; the plasma devicenotifier will spawn an instance of this \
dataengine to tell knotify that it will display such notifications itself. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch depends on the corresponding one for knotify;
With that patch it works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt <span \
style="color: grey">(1123205)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/CMakeLists.txt \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/org.kde.DeviceNotifications.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/3896/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic