[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Routing (un)mounting error notifications via
From:       "Aaron Seigo" <aseigo () kde ! org>
Date:       2010-05-05 17:20:59
Message-ID: 20100505172059.9150.73136 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3896/#review5431
-----------------------------------------------------------

Ship it!


my only concern with this is that we then have exactly one thing at a time that can \
be receiving these errors; e.g i couldn't have the errors showing up in a system tray \
loaded in plasma-windowed at the same time as it is being shown in plasma-desktop or \
plasma-netbook, for example. i really do think that eventually we will want the error \
watchers, such as this DataEngine, to register themselves with KNotify and let \
KNotify multiplex the messages to them. just as we do with notifications. however, \
this is a reasonable and working first step and will allow us to get the integration \
into the UI going.


trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h
 <http://reviewboard.kde.org/r/3896/#comment5120>

    probably doesn't need to be marked as scriptable


- Aaron


On 2010-05-05 16:10:45, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3896/
> -----------------------------------------------------------
> 
> (Updated 2010-05-05 16:10:45)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, and Olivier Goffart.
> 
> 
> Summary
> -------
> 
> This patch provides a dataengine which collects and exposes (un)mounting error \
> notifications; the plasma devicenotifier will spawn an instance of this dataengine \
> to tell knotify that it will display such notifications itself.  
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/CMakeLists.txt 1123205 
> trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/CMakeLists.txt \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.h \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/devicenotificationsengine.cpp \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/org.kde.DeviceNotifications.xml \
> PRE-CREATION  trunk/KDE/kdebase/workspace/plasma/generic/dataengines/devicenotifications/plasma-dataengine-devicenotifications.desktop \
> PRE-CREATION  
> Diff: http://reviewboard.kde.org/r/3896/diff
> 
> 
> Testing
> -------
> 
> This patch depends on the corresponding one for knotify;
> 
> With that patch it works as expected.
> 
> 
> Thanks,
> 
> Jacopo
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]