[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: [PATCH] Suppress errors in Python AppletScripts
From:       Thomas Olsen <tanghus () gmail ! com>
Date:       2010-07-29 7:16:39
Message-ID: 201007290916.49239.tanghus () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 28 July 2010 01:18:22 Aaron J. Seigo wrote:
> On July 27, 2010, Luca Beltrame wrote:
> >  Let me know if it's OK.
> 
> in the patch, is
> 
> +          
> PythonAppletScript.importer.unregister_top_level(self.pluginName)
> 
> the proper indentation for that line? (not a pythonista, so not sure if
> what looks like extra indentation there will matter any.
> 
> otherwise, looks fine.

To me it looks like there's a mix of using tabs and spaces for indentation in 
the patch. That can be seriously confusing when trying to debug ;-)

On a completely different and OT track: is the __dtor__() method a construction 
added by sip? AFAIRC it's not from standard Python where one would use 
__del__() instead.

-- 
Best Regards / Med venlig hilsen

Thomas Olsen

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]