From kde-panel-devel  Thu Jul 29 07:16:39 2010
From: Thomas Olsen <tanghus () gmail ! com>
Date: Thu, 29 Jul 2010 07:16:39 +0000
To: kde-panel-devel
Subject: Re: [PATCH] Suppress errors in Python AppletScripts
Message-Id: <201007290916.49239.tanghus () gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=128038791927309
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0904447819=="

--===============0904447819==
Content-Type: multipart/signed;
  boundary="nextPart1822945.cG6okSpgVI";
  protocol="application/pgp-signature";
  micalg=pgp-sha256
Content-Transfer-Encoding: 7bit

--nextPart1822945.cG6okSpgVI
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Wednesday 28 July 2010 01:18:22 Aaron J. Seigo wrote:
> On July 27, 2010, Luca Beltrame wrote:
> >  Let me know if it's OK.
>=20
> in the patch, is
>=20
> +         =20
> PythonAppletScript.importer.unregister_top_level(self.pluginName)
>=20
> the proper indentation for that line? (not a pythonista, so not sure if
> what looks like extra indentation there will matter any.
>=20
> otherwise, looks fine.

To me it looks like there's a mix of using tabs and spaces for indentation =
in=20
the patch. That can be seriously confusing when trying to debug ;-)

On a completely different and OT track: is the __dtor__() method a construc=
tion=20
added by sip? AFAIRC it's not from standard Python where one would use=20
__del__() instead.

=2D-=20
Best Regards / Med venlig hilsen

Thomas Olsen

--nextPart1822945.cG6okSpgVI
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iF4EABEIAAYFAkxRKtcACgkQge+YkdGJAWg+NQEAkKcCeMIYHwejyQvXktwLf5AN
s2EYRuZ1QhDFAAdY7AcA+QFrRpJAjSvzFdr6xOGmA+EGWwQTgwDr44AYc4bTR87P
=5iCn
-----END PGP SIGNATURE-----

--nextPart1822945.cG6okSpgVI--

--===============0904447819==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============0904447819==--