[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Security updates in kdeplasma-addons for 4.5
From: "Ryan Rix" <ry () n ! rix ! si>
Date: 2010-07-12 9:32:37
Message-ID: 20100712093237.21016.3326 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-11 22:04:59, Chani Armitage wrote:
> >
Commited as of 1148967 and backported to 4.5 as of 1148979. Thanks.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4602/#review6482
-----------------------------------------------------------
On 2010-07-11 21:53:30, Ryan Rix wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4602/
> -----------------------------------------------------------
> =
> (Updated 2010-07-11 21:53:30)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> A whole bunch of security updates for the 4.5 timeframe, they need to go =
out before 4.5 final is tagged, for applets which can or cannot reside on t=
he plasma-overlay screensaver. I feel like a dork for waiting until rc2 to =
remember this patch, and I feel like more of a dork for sending it as an of=
flist mail first, but here is the reviewboard since I suffer from hate-comm=
iting-to-code-i-didn't-write-itis :)
> =
> - add proper attributes to bookmarks' desktop file
> - add proper attributes to opendesktop's desktop file
> - add proper attributes to kdeobservatory's dekstop file
> - add proper attributes to kimpanel's desktop file
> - add proper attributes to pastebin's desktop file
> - add proper attributes to plasmaboard's desktop file
> - add proper attributes to qalculate's desktop file
> - add proper attributes to socialnews's desktop file
> - add proper attributes to spellcheck's desktop file
> - make systemloadviewer's launchapp optional (Made a KRunner DBUS call to=
show system activity window)
> - make weatherstation's launchbrowser optional.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdeplasma-addons/applets/bookmarks/plasma-applet-bookmarks.de=
sktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/community/plasma-applet-opendesktop.=
desktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/kdeobservatory/plasma-applet-kdeobse=
rvatory.desktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/kimpanel/src/plasma-applet-kimpanel.=
desktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/pastebin/plasma-applet-pastebin.desk=
top 1142195 =
> trunk/KDE/kdeplasma-addons/applets/plasmaboard/plasma_applet_plasmaboar=
d.desktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/qalculate/plasma-applet-qalculate.de=
sktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/social-news/activitywidget.cpp 11421=
95 =
> trunk/KDE/kdeplasma-addons/applets/social-news/plasma-applet-opendeskto=
p-activities.desktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/spellcheck/plasma-applet-spellcheck.=
desktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/systemloadviewer/plasma-applet-syste=
mloadviewer.desktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/systemloadviewer/systemloadviewer.cp=
p 1142195 =
> trunk/KDE/kdeplasma-addons/applets/weatherstation/plasma-applet-weather=
station.desktop 1142195 =
> trunk/KDE/kdeplasma-addons/applets/weatherstation/weatherstation.cpp 11=
42195 =
> =
> Diff: http://reviewboard.kde.org/r/4602/diff
> =
> =
> Testing
> -------
> =
> it's been sitting on my system from two weeks not eating $cute_creatures
> =
> =
> Thanks,
> =
> Ryan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4602/">http://reviewboard.kde.org/r/4602/</a>
</td>
</tr>
</table>
<br />
<pre>Commited as of 1148967 and backported to 4.5 as of 1148979. Thanks.</pre>
<br />
<p>- Ryan</p>
<br />
<p>On July 11th, 2010, 9:53 p.m., Ryan Rix wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ryan Rix.</div>
<p style="color: grey;"><i>Updated 2010-07-11 21:53:30</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">A whole bunch of security updates for the 4.5 \
timeframe, they need to go out before 4.5 final is tagged, for applets which can or \
cannot reside on the plasma-overlay screensaver. I feel like a dork for waiting until \
rc2 to remember this patch, and I feel like more of a dork for sending it as an \
offlist mail first, but here is the reviewboard since I suffer from \
hate-commiting-to-code-i-didn't-write-itis :)
- add proper attributes to bookmarks' desktop file
- add proper attributes to opendesktop's desktop file
- add proper attributes to kdeobservatory's dekstop file
- add proper attributes to kimpanel's desktop file
- add proper attributes to pastebin's desktop file
- add proper attributes to plasmaboard's desktop file
- add proper attributes to qalculate's desktop file
- add proper attributes to socialnews's desktop file
- add proper attributes to spellcheck's desktop file
- make systemloadviewer's launchapp optional (Made a KRunner DBUS call to show \
system activity window)
- make weatherstation's launchbrowser optional.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">it's been sitting on my system from two \
weeks not eating $cute_creatures</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdeplasma-addons/applets/bookmarks/plasma-applet-bookmarks.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/community/plasma-applet-opendesktop.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/kdeobservatory/plasma-applet-kdeobservatory.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/kimpanel/src/plasma-applet-kimpanel.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/pastebin/plasma-applet-pastebin.desktop <span \
style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/plasmaboard/plasma_applet_plasmaboard.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/qalculate/plasma-applet-qalculate.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/social-news/activitywidget.cpp <span \
style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/social-news/plasma-applet-opendesktop-activities.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/spellcheck/plasma-applet-spellcheck.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/systemloadviewer/plasma-applet-systemloadviewer.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/systemloadviewer/systemloadviewer.cpp <span \
style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/weatherstation/plasma-applet-weatherstation.desktop \
<span style="color: grey">(1142195)</span></li>
<li>trunk/KDE/kdeplasma-addons/applets/weatherstation/weatherstation.cpp <span \
style="color: grey">(1142195)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4602/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic