[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adds support for corner widgets in Plasma::TabBar
From: "Marco Martin" <notmart () gmail ! com>
Date: 2010-07-12 8:06:40
Message-ID: 20100712080640.19492.55207 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4537/#review6484
-----------------------------------------------------------
Ship it!
i think now it's perfect(tm)
- Marco
On 2010-07-11 21:06:03, Giulio Camuffo wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4537/
> -----------------------------------------------------------
> =
> (Updated 2010-07-11 21:06:03)
> =
> =
> Review request for Plasma and Marco Martin.
> =
> =
> Summary
> -------
> =
> This patch adds two methods that allow to put two QGraphicsWidget in the =
top left and top right corner of the tab bar, like it is possible with QTab=
Widget.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 =
> trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 =
> =
> Diff: http://reviewboard.kde.org/r/4537/diff
> =
> =
> Testing
> -------
> =
> Tested, it works, but there's one thing that annoys me and I don't how to=
solve in a clean way: when there are no tabs the NativeTabBar becomes a bi=
t smaller in height and the widgets resize accordingly.
> =
> =
> Screenshots
> -----------
> =
> added two Plasma::PushButton
> http://reviewboard.kde.org/r/4537/s/446/
> =
> =
> Thanks,
> =
> Giulio
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4537/">http://reviewboard.kde.org/r/4537/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre>i think now it's perfect(tm)</pre>
<br />
<p>- Marco</p>
<br />
<p>On July 11th, 2010, 9:06 p.m., Giulio Camuffo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Giulio Camuffo.</div>
<p style="color: grey;"><i>Updated 2010-07-11 21:06:03</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adds two methods that allow to put \
two QGraphicsWidget in the top left and top right corner of the tab bar, like it is \
possible with QTabWidget.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Tested, it works, but there's one thing \
that annoys me and I don't how to solve in a clean way: when there are no tabs \
the NativeTabBar becomes a bit smaller in height and the widgets resize \
accordingly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/widgets/tabbar.h <span style="color: \
grey">(1147219)</span></li>
<li>trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp <span style="color: \
grey">(1147219)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4537/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4537/s/446/"><img \
src="http://reviewboard.kde.org/media/uploaded/images/2010/07/07/tabbar_400x100.png" \
style="border: 1px black solid;" alt="added two Plasma::PushButton" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic