'Re: Review Request: Better behaviour of the bookmarks runner regarding'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Better behaviour of the bookmarks runner regarding
From:       "Jan Gerrit Marker" <jangmarker () weiler-marker ! com>
Date:       2010-06-22 16:41:18
Message-ID: 20100622164118.13447.14514 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4414/
-----------------------------------------------------------

(Updated 2010-06-22 16:41:18.325281)

Review request for Plasma.

Changes
-------

Correct the last fix about context validation.

Summary
-------

Corrects the behavior of the bookmarks runner regarding Firefox:
1. Firefox intern bookmarks (like the "Recently used bookmarks" folder) are=
 not shown
2. Only bookmarks with a non empty name and url are shown
3. The profile written to the config file is updated if it does not exist a=
nymore

Additionally I polished the Firefox regarding method.
I did not commit directly because I was not sure whether it is allowed at t=
his point of the KDE SC development.

Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksru=
nner.cpp 1141326 =

Diff: http://reviewboard.kde.org/r/4414/diff

Testing
-------

I have tested it with current trunk - everything seems to be ok.

Thanks,

Jan Gerrit

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4414/">http://reviewboard.kde.org/r/4414/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Jan Gerrit Marker.</div>

<p style="color: grey;"><i>Updated 2010-06-22 16:41:18.325281</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Correct the last fix about context \
validation.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">Corrects the behavior of the bookmarks runner \
regarding Firefox: 1. Firefox intern bookmarks (like the &quot;Recently used \
bookmarks&quot; folder) are not shown 2. Only bookmarks with a non empty name and url \
are shown 3. The profile written to the config file is updated if it does not exist \
anymore

Additionally I polished the Firefox regarding method.
I did not commit directly because I was not sure whether it is allowed at this point \
of the KDE SC development.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">I have tested it with current trunk - \
everything seems to be ok.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp \
<span style="color: grey">(1141326)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4414/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 