--===============1637225170== Content-Type: multipart/alternative; boundary="===============0948863508223076176==" --===============0948863508223076176== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4414/ ----------------------------------------------------------- (Updated 2010-06-22 16:41:18.325281) Review request for Plasma. Changes ------- Correct the last fix about context validation. Summary ------- Corrects the behavior of the bookmarks runner regarding Firefox: 1. Firefox intern bookmarks (like the "Recently used bookmarks" folder) are= not shown 2. Only bookmarks with a non empty name and url are shown 3. The profile written to the config file is updated if it does not exist a= nymore Additionally I polished the Firefox regarding method. I did not commit directly because I was not sure whether it is allowed at t= his point of the KDE SC development. Diffs (updated) ----- /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksru= nner.cpp 1141326 = Diff: http://reviewboard.kde.org/r/4414/diff Testing ------- I have tested it with current trunk - everything seems to be ok. Thanks, Jan Gerrit --===============0948863508223076176== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4414/

Review request for Plasma.
By Jan Gerrit Marker.

Updated 2010-06-22 16:41:18.325281

Changes 
Correct the last fix about context=
 validation.

Descripti= on 

Corrects the behavior of the bookm=
arks runner regarding Firefox:
1. Firefox intern bookmarks (like the "Recently used bookmarks" f=
older) are not shown
2. Only bookmarks with a non empty name and url are shown
3. The profile written to the config file is updated if it does not exist a=
nymore

Additionally I polished the Firefox regarding method.
I did not commit directly because I was not sure whether it is allowed at t=
his point of the KDE SC development.

Testing <= /h1> 
I have tested it with current trun=
k - everything seems to be ok.

Diffs= (updated)

  • /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmark= srunner.cpp (1141326)

View Diff
--===============0948863508223076176==-- --===============1637225170== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1637225170==--