[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Improve display of week number in calendar applet
From: "John Layt" <johnlayt () googlemail ! com>
Date: 2010-06-21 21:03:51
Message-ID: 20100621210351.23220.14220 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4419/#review6222
-----------------------------------------------------------
You can test RTL by running "plasmoidviewer calendar -reverse". Alternativ=
e calendars are even easier, just right-click to configure. Anyway, they l=
ook OK. I might tweak the 'most days' formula. Thanks!
- John
On 2010-06-21 06:07:40, Alain Boyer wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4419/
> -----------------------------------------------------------
> =
> (Updated 2010-06-21 06:07:40)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> This patch is a temporary workaround for bugs 238116 and 224344. I am cal=
ling it temporary since it is my understanding that the drawing of the cale=
ndar applet will be worked on and improved for 4.6. Is this correct?
> =
> Basically, only one week number is shown when there is not enough room to=
display two week numbers in the calendar applet (two week numbers are disp=
layed when the first day of the week is not Monday). Instead of simply disp=
laying the first week number, an attempt is made to display the week number=
that has the most amount of days in the calendar row.
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1140389 =
> =
> Diff: http://reviewboard.kde.org/r/4419/diff
> =
> =
> Testing
> -------
> =
> Tested with Georgian calendar and seems to give correct behavior no matte=
r which day of the week is set as the first day of the week.
> =
> Needs testing with other calendars and RTL layouts.
> =
> =
> Thanks,
> =
> Alain
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4419/">http://reviewboard.kde.org/r/4419/</a>
</td>
</tr>
</table>
<br />
<pre>You can test RTL by running "plasmoidviewer calendar -reverse". \
Alternative calendars are even easier, just right-click to configure. Anyway, they \
look OK. I might tweak the 'most days' formula. Thanks!</pre> <br />
<p>- John</p>
<br />
<p>On June 21st, 2010, 6:07 a.m., Alain Boyer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alain Boyer.</div>
<p style="color: grey;"><i>Updated 2010-06-21 06:07:40</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch is a temporary workaround for bugs \
238116 and 224344. I am calling it temporary since it is my understanding that the \
drawing of the calendar applet will be worked on and improved for 4.6. Is this \
correct?
Basically, only one week number is shown when there is not enough room to display two \
week numbers in the calendar applet (two week numbers are displayed when the first \
day of the week is not Monday). Instead of simply displaying the first week number, \
an attempt is made to display the week number that has the most amount of days in the \
calendar row.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Tested with Georgian calendar and seems to \
give correct behavior no matter which day of the week is set as the first day of the \
week.
Needs testing with other calendars and RTL layouts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp <span \
style="color: grey">(1140389)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4419/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic