From kde-panel-devel Mon Jun 21 21:03:51 2010 From: "John Layt" Date: Mon, 21 Jun 2010 21:03:51 +0000 To: kde-panel-devel Subject: Re: Review Request: Improve display of week number in calendar applet Message-Id: <20100621210351.23220.14220 () localhost> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=127715427317041 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0176369291==" --===============0176369291== Content-Type: multipart/alternative; boundary="===============7036119653303015251==" --===============7036119653303015251== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4419/#review6222 ----------------------------------------------------------- You can test RTL by running "plasmoidviewer calendar -reverse". Alternativ= e calendars are even easier, just right-click to configure. Anyway, they l= ook OK. I might tweak the 'most days' formula. Thanks! - John On 2010-06-21 06:07:40, Alain Boyer wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4419/ > ----------------------------------------------------------- > = > (Updated 2010-06-21 06:07:40) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > This patch is a temporary workaround for bugs 238116 and 224344. I am cal= ling it temporary since it is my understanding that the drawing of the cale= ndar applet will be worked on and improved for 4.6. Is this correct? > = > Basically, only one week number is shown when there is not enough room to= display two week numbers in the calendar applet (two week numbers are disp= layed when the first day of the week is not Monday). Instead of simply disp= laying the first week number, an attempt is made to display the week number= that has the most amount of days in the calendar row. > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp 1140389 = > = > Diff: http://reviewboard.kde.org/r/4419/diff > = > = > Testing > ------- > = > Tested with Georgian calendar and seems to give correct behavior no matte= r which day of the week is set as the first day of the week. > = > Needs testing with other calendars and RTL layouts. > = > = > Thanks, > = > Alain > = > --===============7036119653303015251== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4419/ 

You can test RTL by running "plasmoidviewer calendar -reverse&qu=
ot;.  Alternative calendars are even easier, just right-click to configure.=
  Anyway, they look OK.  I might tweak the 'most days' formula.  Th=
anks!

- John


On June 21st, 2010, 6:07 a.m., Alain Boyer wrote:

Review request for Plasma.
By Alain Boyer.

Updated 2010-06-21 06:07:40

Descripti= on 

This patch is a temporary workarou=
nd for bugs 238116 and 224344. I am calling it temporary since it is my und=
erstanding that the drawing of the calendar applet will be worked on and im=
proved for 4.6. Is this correct?

Basically, only one week number is shown when there is not enough room to d=
isplay two week numbers in the calendar applet (two week numbers are displa=
yed when the first day of the week is not Monday). Instead of simply displa=
ying the first week number, an attempt is made to display the week number t=
hat has the most amount of days in the calendar row.

Testing <= /h1> 
Tested with Georgian calendar and =
seems to give correct behavior no matter which day of the week is set as th=
e first day of the week.

Needs testing with other calendars and RTL layouts.

Diffs=

  • /trunk/KDE/kdebase/workspace/libs/plasmaclock/calendartable.cpp (1140389)

View Diff
--===============7036119653303015251==-- --===============0176369291== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0176369291==--