[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Remove confusing destkop-theme-details kcm from
From:       "Jeremy Whiting" <jpwhiting () kde ! org>
Date:       2010-05-15 0:13:02
Message-ID: 20100515001302.7053.73952 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3960/
-----------------------------------------------------------

(Updated 2010-05-15 00:13:02.120883)


Review request for Plasma.


Changes
-------

Ok, I made the move.  I moved the style/workspace tab out into a new kcm called \
desktoptheme.  Moved the desktopthemedetails into a tab in that new kcm, removed the \
workspace tab from the style kcm, etc.  I believe I covered all the bases here (and \
removed some unneeded #includes in the process).  But let me know if I need to tweak \
anything in here before committing (and if it's ok to commit after feature freeze but \
before string freeze).


Summary
-------

desktop-theme-details kcm is very confusing on  first run.  Many users expect it to \
set the global default plasma theme, and most users probably don't even care for the \
functionality it exposes.  So this patch hides it, and it can still be called by \
kcmshell4 destkopthemedetails.

I am willing to write a script that calls kcmshell4 desktopthemedetails but wonder if \
the users that care to use this probably know that command already anyway.

Also, I thought of making this into a standalone app like oxygen-settings, but as a \
kcm it can be re-introduced into a "TweakUi" like app at a later time if someone \
wants to write such a thing. :)


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/kcontrol/CMakeLists.txt 1123694 
  trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/CMakeLists.txt PRE-CREATION 
  trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/desktopthemedetails.h \
PRE-CREATION   trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/desktopthemedetails.cpp \
PRE-CREATION   trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/kcmdesktoptheme.h \
PRE-CREATION   trunk/KDE/kdebase/workspace/kcontrol/desktoptheme/kcmdesktoptheme.cpp \
PRE-CREATION   trunk/KDE/kdebase/workspace/kcontrol/style/CMakeLists.txt 1123694 
  trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.h 1123694 
  trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp 1123694 
  trunk/KDE/kdebase/workspace/libs/kephal/service/kephalservice.cpp 1123694 
  trunk/KDE/kdebase/workspace/plasma/tools/CMakeLists.txt 1123694 
  trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/CMakeLists.txt 1123694 \
  trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/DesktopThemeDetails.ui \
1123694   trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/Messages.sh \
1123694   trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/desktopthemedetails.h \
1123694   trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/desktopthemedetails.cpp \
1123694   trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/desktopthemedetails.desktop \
1123694 

Diff: http://reviewboard.kde.org/r/3960/diff


Testing
-------

Built and installed with this change, and it works here. kcmshell4 \
destkopthemedetails still launches it even though it doesn't appear in \
system-settings any longer.


Thanks,

Jeremy

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]