[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Remove confusing destkop-theme-details kcm from
From:       "Ben Cooksley" <sourtooth () gmail ! com>
Date:       2010-05-13 20:31:50
Message-ID: 20100513203150.1600.14335 () localhost
[Download RAW message or body]



> On 2010-05-13 09:01:41, Marco Martin wrote:
> > it could be launched from a button that in turn resides into the theme kcm (that \
> > should really be moved from where it now to desktop appearance) but both of those \
> > things are quite too late for the freeze i think
> 
> Aaron Seigo wrote:
> "that should really be moved from where it now to desktop appearance"
> 
> this is residual from the reorgnization. we only just recently merged all the \
> appearance kcms and then some people went and messed around with the kcm ordering \
> in system settings. we have a whole new kind of mess on our hands now. i told them \
> this would happen; i really wish people would listen to me a bit more. :/ 
> anyways ... yes, i agree that a path from the simple "pick a theme" that covers \
> most needs to the more complex "create a custom theme" tool is what's called for \
> here. i don't think it's too late for the freeze though, this is some pretty bad \
> usability. 
> Andrew Lake wrote:
> I wrote the the kcm and I've really struggled with where it should go or how the \
> name could perhaps be changed to better reflect what it does, or how else it could \
> be improved.  I've also just considered removing it and maintaining it as a \
> separate app.  I confess it really can be confusing when users are hunting down \
> where to change the theme when the current theme changer in on a tab in Style and \
> this kcm shows up a the top level (albeit under Advanced).  No ego here.  If \
> hiding/removing it is best, I'm fine with that.

Merged all the appearance? Colors is still seperate....

In any case, seperating out the Plasma theme part of the Appearance KCM was on my \
list of things to do, but time ran out before the feature freeze. Moving it to the \
Workspace Appearance area would be an acceptable workaround until it can be split.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3960/#review5649
-----------------------------------------------------------


On 2010-05-13 02:46:20, Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3960/
> -----------------------------------------------------------
> 
> (Updated 2010-05-13 02:46:20)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> desktop-theme-details kcm is very confusing on  first run.  Many users expect it to \
> set the global default plasma theme, and most users probably don't even care for \
> the functionality it exposes.  So this patch hides it, and it can still be called \
> by kcmshell4 destkopthemedetails. 
> I am willing to write a script that calls kcmshell4 desktopthemedetails but wonder \
> if the users that care to use this probably know that command already anyway. 
> Also, I thought of making this into a standalone app like oxygen-settings, but as a \
> kcm it can be re-introduced into a "TweakUi" like app at a later time if someone \
> wants to write such a thing. :) 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/plasma/tools/desktopthemedetails/desktopthemedetails.desktop \
> 1123694  
> Diff: http://reviewboard.kde.org/r/3960/diff
> 
> 
> Testing
> -------
> 
> Built and installed with this change, and it works here. kcmshell4 \
> destkopthemedetails still launches it even though it doesn't appear in \
> system-settings any longer. 
> 
> Thanks,
> 
> Jeremy
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]