[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add a tooltip to battery monitor applet
From:       Kåre Särs <kare.sars () iki ! fi>
Date:       2009-10-30 7:52:05
Message-ID: 20091030075205.12660.11162 () localhost
[Download RAW message or body]



> On 2009-10-29 20:55:56, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, line 63
> > <http://reviewboard.kde.org/r/2010/diff/1/?file=13515#file13515line63>
> > 
> > interestingly, you don't need to include this one as ToolTipManager drags it in \
> > for us. not a big deal at all, just a perhaps-interesting note :)

OK, that was just copy-pasted from the System Load Viewer :)


> On 2009-10-29 20:55:56, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, lines \
> > 1115-1122 <http://reviewboard.kde.org/r/2010/diff/1/?file=13515#file13515line1115>
> >  
> > i believe for translation purposes, this should be all on the same line and \
> > shouldn't be using arg() either, e.g.: 
> > if (status == "Discharging") {
> > content += i18n("Discharging: %1 charged", battery_charge);
> > } else {
> > content += i18n("Charging: %1 charged", battery_charge);
> > }
> > 
> > content.append("<br>"); // keep that out of the i18n

Very true.


> On 2009-10-29 20:55:56, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, line 1123
> > <http://reviewboard.kde.org/r/2010/diff/1/?file=13515#file13515line1123>
> > 
> > we don't show time remaining; it's a bogus number.

I had not read the "battery plasmoid and remaining time.." thread on plasma-devel and \
I must say that I'm disappointed :(

I have two laptops, one with ~1h battery time and the other ~4h. How is the user \
supposed to estimate the remaining time when 10% might mean 6 or 24 minutes depending \
on the computer. The computer estimated times on my laptops are _way_ better than \
what I could ever estimate.

I would have thought that a tool-tip containing "Estimated" would have been a good \
enough compromise. 

If I want a battery applet that shows the _estimated_ remaining time without needing \
to edit a configuration file, that is by the way very hard to find and edit, should I \
make another one in another place?


- Kåre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2010/#review2854
-----------------------------------------------------------


On 2009-10-29 20:26:00, Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2010/
> -----------------------------------------------------------
> 
> (Updated 2009-10-29 20:26:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This path adds a tool-tip for the battery-monitor applet. The tool-tip contains \
> charge percentage and estimated time left. The patch also changes the \
> CMakeLists.txt to make it possible to compile the applet standalone.  
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/CMakeLists.txt 1041319 
> trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1041319 
> trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1041319 
> 
> Diff: http://reviewboard.kde.org/r/2010/diff
> 
> 
> Testing
> -------
> 
> I'm not running trunk, so I had to comment out the setStatus() functions (not done \
> in the patch). 
> 
> Thanks,
> 
> Kåre
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]