[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Keyboard navigation support for Tasks applet
From:       "Michal Dutkiewicz" <emdeck () gmail ! com>
Date:       2009-08-31 14:04:45
Message-ID: 20090831140445.6223.33920 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1482/
-----------------------------------------------------------

(Updated 2009-08-31 14:04:45.714405)


Review request for Plasma, Aaron Seigo and Marco Martin.


Changes
-------

Ported wheelEvent() to use the same logic for changing active task (hope that it is \
right approach). By the way, why wheelEvent() is protected slot here?


Summary
-------

This patch adds support for [Shift + ] Tab navigation (and Enter / Return to activate \
item) in Tasks plasmoid. In order to work it needs fixing of panel focusing issue (as \
discussed on mailing list), I could apply mine method for temporary use if needed.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp 1017535 

Diff: http://reviewboard.kde.org/r/1482/diff


Testing
-------

Tested in plasmoidviwer and works (groups may need additional testing).


Thanks,

Michal

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]