[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Keyboard navigation support for Tasks applet
From: "Michal Dutkiewicz" <emdeck () gmail ! com>
Date: 2009-08-31 9:03:28
Message-ID: 20090831090328.6242.13370 () localhost
[Download RAW message or body]
> On 2009-08-31 08:58:13, Marco Martin wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp, line 696
> > <http://reviewboard.kde.org/r/1482/diff/1/?file=10850#file10850line696>
> >
> > should be circular and logic for this is already in the wheel event, you should \
> > use that ()then wheelevent calling focusPrevNex (don't really like the name btw)
This is Qt built in method, I'll port wheel event to use it (using built in handling \
of Tab is best way I think ;-)). But there is one problem, in case of wheel event we \
can simply activate window but in case of [Shift + ] Tab it is not so easy, \
especially before fixing focus for panels, so I'll stick with Enter / Return to \
activate when using keyboard.
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1482/#review2208
-----------------------------------------------------------
On 2009-08-30 20:46:50, Michal Dutkiewicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1482/
> -----------------------------------------------------------
>
> (Updated 2009-08-30 20:46:50)
>
>
> Review request for Plasma, Aaron Seigo and Marco Martin.
>
>
> Summary
> -------
>
> This patch adds support for [Shift + ] Tab navigation (and Enter / Return to \
> activate item) in Tasks plasmoid. In order to work it needs fixing of panel \
> focusing issue (as discussed on mailing list), I could apply mine method for \
> temporary use if needed.
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 1017471
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 1017471
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h 1017471
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1017471
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h 1017471
> /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp 1017471
>
> Diff: http://reviewboard.kde.org/r/1482/diff
>
>
> Testing
> -------
>
> Tested in plasmoidviwer and works (groups may need additional testing).
>
>
> Thanks,
>
> Michal
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic