[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: tasks widget hacking
From: "=?ISO-8859-1?Q?Alexis_M=E9nard?=" <menard () kde ! org>
Date: 2008-12-02 12:01:58
Message-ID: 81941aea0812020401q153059dck5c857120c2ebacec () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Tue, Dec 2, 2008 at 12:02 PM, Christian Mollekopf
<chrigi_1@fastmail.fm>wrote:
> Am 02.12.2008, 11:43 Uhr, schrieb Marco Martin <notmart@gmail.com>:
>
> > On Tuesday 02 December 2008, Alexis Ménard wrote:
> >> And the layout is recreated again and again, i am sure we can find a
> >> solution for that.
> >
> > time ago i tried to remove that thing, it resulted in empty holes still
> > sized
> > as there were items in it, so then tried with a simple qt program and the
> > problem wasn't there, so it must be a problem somewhere in
> > layoutwidget.cpp,
> > but it's pretty complex, really wasn't able to track it down
>
> Since i did most of this stuff i should attend the meeting as well =)
> Good for me is between 20.00- 24.00 GMT+1, today for instance would be
> good.
>
> The layout recreation is a workaround since the QGraphicsGridLayout
> doesn't remove the items properly.
> I think Aaron and Marco agreed on this workaround an we will have to keep
> it that way until it's fixed in QT.
>
If the problem is in Qt then i will fix it, it's my job. And removing items
should work and must work...
I have already used QGraphicsGridLayout and it should work as far as i know
and the last time i used it.
Anyway if the bug exist why don't you write to the support of Qt Software
about that?
I have actually screen all QGraphicsLayout tasks and there are no such of
things. So the bug will never be fixed if it exist.
Anyway i will take a look at it...
>
> Regards,
>
> Christian
>
> >
> >> 2008/12/2 Aaron J. Seigo <aseigo@kde.org>
> >>
> >> > hi...
> >> >
> >> > i'd like to have a tasks widget hacking day.
> >> >
> >> > the reason for this i that the code is something of a mess internally
> >> and
> >> > imho
> >> > it's unmaintainable in its current state. i say this because changing
> >> > little
> >> > things in one place often create rather unexpected results; there's a
> >> > good amount of unreachable code; there's what looks to be some pretty
> >> > obvious memory leaks (e.g. Tasks::m_groupTaskItems never seems to have
> >> > items removed
> >> > from it!); Tasks does bookkeeping, but for only some things, and this
> >> > bookkeeping is controlled from Tasks, LayoutWidget *and*
> >> TaskGroupItem!
> >> >
> >> > there are bugs that sometimes results in "holes" showing up in the
> >> > layout, grouping not working reliably on start up and more.
> >> >
> >> > if we ship with it like this, we will hate ourselves later.
> >> >
> >> > unfortunately, i'm not particularly sure what all the reasons and
> >> > rationals are for some of the code decisions.
> >> >
> >> > so if you have been working on the tasks widget in the last month or
> >> two,
> >> > please respond in this thread with when would be a good time and day
> >> for
> >> > you
> >> > so we can get together on irc and sort this thing out. =)
> >> >
> >> > --
> >> > Aaron J. Seigo
> >> > humru othro a kohnu se
> >> > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
> >> >
> >> > KDE core developer sponsored by Qt Software
> >> >
> >> >
> >> > _______________________________________________
> >> > Plasma-devel mailing list
> >> > Plasma-devel@kde.org
> >> > https://mail.kde.org/mailman/listinfo/plasma-devel
> >
> >
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
>
> --
> Erstellt mit Operas revolutionärem E-Mail-Modul:
> http://www.opera.com/mail/
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">On Tue, Dec 2, 2008 at 12:02 PM, Christian Mollekopf \
<span dir="ltr"><<a \
href="mailto:chrigi_1@fastmail.fm">chrigi_1@fastmail.fm</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Am 02.12.2008, 11:43 Uhr, \
schrieb Marco Martin <<a \
href="mailto:notmart@gmail.com">notmart@gmail.com</a>>:<br> <div \
class="Ih2E3d"><br> > On Tuesday 02 December 2008, Alexis Ménard wrote:<br>
>> And the layout is recreated again and again, i am sure we can find a<br>
>> solution for that.<br>
><br>
> time ago i tried to remove that thing, it resulted in empty holes still<br>
> sized<br>
> as there were items in it, so then tried with a simple qt program and the<br>
> problem wasn't there, so it must be a problem somewhere in<br>
> layoutwidget.cpp,<br>
> but it's pretty complex, really wasn't able to track it down<br>
<br>
</div>Since i did most of this stuff i should attend the meeting as well =)<br>
Good for me is between 20.00- 24.00 GMT+1, today for instance would be<br>
good.<br>
<br>
The layout recreation is a workaround since the QGraphicsGridLayout<br>
doesn't remove the items properly.<br>
I think Aaron and Marco agreed on this workaround an we will have to keep<br>
it that way until it's fixed in QT.<br>
</blockquote><div><br>If the problem is in Qt then i will fix it, it's my job. \
And removing items should work and must work...<br>I have already used \
QGraphicsGridLayout and it should work as far as i know and the last time i used \
it.<br> Anyway if the bug exist why don't you write to the support of Qt Software \
about that?<br>I have actually screen all QGraphicsLayout tasks and there are no such \
of things. So the bug will never be fixed if it exist.<br> <br>Anyway i will take a \
look at it...<br><br> </div><blockquote class="gmail_quote" style="border-left: \
1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br> \
Regards,<br> <br>
Christian<br>
<div><div></div><div class="Wj3C7c"><br>
><br>
>> 2008/12/2 Aaron J. Seigo <<a \
href="mailto:aseigo@kde.org">aseigo@kde.org</a>><br> >><br>
>> > hi...<br>
>> ><br>
>> > i'd like to have a tasks widget hacking day.<br>
>> ><br>
>> > the reason for this i that the code is something of a mess \
internally<br> >> and<br>
>> > imho<br>
>> > it's unmaintainable in its current state. i say this because \
changing<br> >> > little<br>
>> > things in one place often create rather unexpected results; there's \
a<br> >> > good amount of unreachable code; there's what looks to be \
some pretty<br> >> > obvious memory leaks (e.g. Tasks::m_groupTaskItems \
never seems to have<br> >> > items removed<br>
>> > from it!); Tasks does bookkeeping, but for only some things, and \
this<br> >> > bookkeeping is controlled from Tasks, LayoutWidget *and*<br>
>> TaskGroupItem!<br>
>> ><br>
>> > there are bugs that sometimes results in "holes" showing up \
in the<br> >> > layout, grouping not working reliably on start up and \
more.<br> >> ><br>
>> > if we ship with it like this, we will hate ourselves later.<br>
>> ><br>
>> > unfortunately, i'm not particularly sure what all the reasons \
and<br> >> > rationals are for some of the code decisions.<br>
>> ><br>
>> > so if you have been working on the tasks widget in the last month \
or<br> >> two,<br>
>> > please respond in this thread with when would be a good time and \
day<br> >> for<br>
>> > you<br>
>> > so we can get together on irc and sort this thing out. =)<br>
>> ><br>
>> > --<br>
>> > Aaron J. Seigo<br>
>> > humru othro a kohnu se<br>
>> > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 \
DB43<br> >> ><br>
>> > KDE core developer sponsored by Qt Software<br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > Plasma-devel mailing list<br>
>> > <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
>> > <a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> ><br>
><br>
> _______________________________________________<br>
> Plasma-devel mailing list<br>
> <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> <br>
<br>
<br>
</div></div><font color="#888888">--<br>
Erstellt mit Operas revolutionärem E-Mail-Modul: <a href="http://www.opera.com/mail/" \
target="_blank">http://www.opera.com/mail/</a><br> </font><div><div></div><div \
class="Wj3C7c">_______________________________________________<br> Plasma-devel \
mailing list<br> <a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
</div></div></blockquote></div><br>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic