From kde-panel-devel Tue Dec 02 12:01:58 2008 From: "=?ISO-8859-1?Q?Alexis_M=E9nard?=" Date: Tue, 02 Dec 2008 12:01:58 +0000 To: kde-panel-devel Subject: Re: tasks widget hacking Message-Id: <81941aea0812020401q153059dck5c857120c2ebacec () mail ! gmail ! com> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=122821936608945 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1889141841==" --===============1889141841== Content-Type: multipart/alternative; boundary="----=_Part_132542_25842899.1228219318691" ------=_Part_132542_25842899.1228219318691 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tue, Dec 2, 2008 at 12:02 PM, Christian Mollekopf wrote: > Am 02.12.2008, 11:43 Uhr, schrieb Marco Martin : > > > On Tuesday 02 December 2008, Alexis M=E9nard wrote: > >> And the layout is recreated again and again, i am sure we can find a > >> solution for that. > > > > time ago i tried to remove that thing, it resulted in empty holes still > > sized > > as there were items in it, so then tried with a simple qt program and t= he > > problem wasn't there, so it must be a problem somewhere in > > layoutwidget.cpp, > > but it's pretty complex, really wasn't able to track it down > > Since i did most of this stuff i should attend the meeting as well =3D) > Good for me is between 20.00- 24.00 GMT+1, today for instance would be > good. > > The layout recreation is a workaround since the QGraphicsGridLayout > doesn't remove the items properly. > I think Aaron and Marco agreed on this workaround an we will have to keep > it that way until it's fixed in QT. > If the problem is in Qt then i will fix it, it's my job. And removing items should work and must work... I have already used QGraphicsGridLayout and it should work as far as i know and the last time i used it. Anyway if the bug exist why don't you write to the support of Qt Software about that? I have actually screen all QGraphicsLayout tasks and there are no such of things. So the bug will never be fixed if it exist. Anyway i will take a look at it... > > Regards, > > Christian > > > > >> 2008/12/2 Aaron J. Seigo > >> > >> > hi... > >> > > >> > i'd like to have a tasks widget hacking day. > >> > > >> > the reason for this i that the code is something of a mess internall= y > >> and > >> > imho > >> > it's unmaintainable in its current state. i say this because changin= g > >> > little > >> > things in one place often create rather unexpected results; there's = a > >> > good amount of unreachable code; there's what looks to be some prett= y > >> > obvious memory leaks (e.g. Tasks::m_groupTaskItems never seems to ha= ve > >> > items removed > >> > from it!); Tasks does bookkeeping, but for only some things, and thi= s > >> > bookkeeping is controlled from Tasks, LayoutWidget *and* > >> TaskGroupItem! > >> > > >> > there are bugs that sometimes results in "holes" showing up in the > >> > layout, grouping not working reliably on start up and more. > >> > > >> > if we ship with it like this, we will hate ourselves later. > >> > > >> > unfortunately, i'm not particularly sure what all the reasons and > >> > rationals are for some of the code decisions. > >> > > >> > so if you have been working on the tasks widget in the last month or > >> two, > >> > please respond in this thread with when would be a good time and day > >> for > >> > you > >> > so we can get together on irc and sort this thing out. =3D) > >> > > >> > -- > >> > Aaron J. Seigo > >> > humru othro a kohnu se > >> > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > >> > > >> > KDE core developer sponsored by Qt Software > >> > > >> > > >> > _______________________________________________ > >> > Plasma-devel mailing list > >> > Plasma-devel@kde.org > >> > https://mail.kde.org/mailman/listinfo/plasma-devel > > > > > > _______________________________________________ > > Plasma-devel mailing list > > Plasma-devel@kde.org > > https://mail.kde.org/mailman/listinfo/plasma-devel > > > > -- > Erstellt mit Operas revolution=E4rem E-Mail-Modul: > http://www.opera.com/mail/ > _______________________________________________ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > ------=_Part_132542_25842899.1228219318691 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline

On Tue, Dec 2, 2008 at 12:02 PM, Christi= an Mollekopf <= chrigi_1@fastmail.fm> wrote:
Am 02.12.2008, 11:43 Uhr, schrieb Marco Martin <notmart@gmail.com>:

> On Tuesday 02 December 2008, Alexis M=E9nard wrote:
>> And the layout is recreated again and again, i am sure we can find= a
>> solution for that.
>
> time ago i tried to remove that thing, it resulted in empty holes stil= l
> sized
> as there were items in it, so then tried with a simple qt program and = the
> problem wasn't there, so it must be a problem somewhere in
> layoutwidget.cpp,
> but it's pretty complex, really wasn't able to track it down
Since i did most of this stuff i should attend the meeting as well = =3D)
Good for me is between 20.00- 24.00 GMT+1, today for instance would be
good.

The layout recreation is a workaround since the QGraphicsGridLayout
doesn't remove the items properly.
I think Aaron and Marco agreed on this workaround an we will have to keep it that way until it's fixed in QT.

If the problem is in Qt then i will fix it, it's = my job. And removing items should work and must work...
I have already u= sed QGraphicsGridLayout and it should work as far as i know and the last ti= me i used it.
Anyway if the bug exist why don't you write to the support of Qt Softwa= re about that?
I have actually screen all QGraphicsLayout tasks and ther= e are no such of things. So the bug will never be fixed if it exist.

Anyway i will take a look at it...

 

Regards,

Christian

>
>> 2008/12/2 Aaron J. Seigo <ase= igo@kde.org>
>>
>> > hi...
>> >
>> > i'd like to have a tasks widget hacking day.
>> >
>> > the reason for this i that the code is something of a mess in= ternally
>> and
>> > imho
>> > it's unmaintainable in its current state. i say this beca= use changing
>> > little
>> > things in one place often create rather unexpected results; t= here's a
>> > good amount of unreachable code; there's what looks to be= some pretty
>> > obvious memory leaks (e.g. Tasks::m_groupTaskItems never seem= s to have
>> > items removed
>> > from it!); Tasks does bookkeeping, but for only some things, = and this
>> > bookkeeping is controlled from Tasks, LayoutWidget *and*
>> TaskGroupItem!
>> >
>> > there are bugs that sometimes results in "holes" sh= owing up in the
>> > layout, grouping not working reliably on start up and more. >> >
>> > if we ship with it like this, we will hate ourselves later. >> >
>> > unfortunately, i'm not particularly sure what all the rea= sons and
>> > rationals are for some of the code decisions.
>> >
>> > so if you have been working on the tasks widget in the last m= onth or
>> two,
>> > please respond in this thread with when would be a good time = and day
>> for
>> > you
>> > so we can get together on irc and sort this thing out. =3D) >> >
>> > --
>> > Aaron J. Seigo
>> > humru othro a kohnu se
>> > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB= 1 A7F1 DB43
>> >
>> > KDE core developer sponsored by Qt Software
>> >
>> >
>> > _______________________________________________
>> > Plasma-devel mailing list
>> > Plasma-devel@kde.org<= /a>
>> >
https://mail.kde.org/mailman/listinfo/plasma-devel<= br> >
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel



--
Erstellt mit Operas revolution=E4rem E-Mail-Modul: http://www.opera.com/mail/
______________________________= _________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

------=_Part_132542_25842899.1228219318691-- --===============1889141841== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1889141841==--