[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Patch to mousePressEvent in Plasma lib.
From:       "=?ISO-8859-1?Q?Alexis_M=E9nard?=" <menard () kde ! org>
Date:       2008-11-26 16:02:09
Message-ID: 81941aea0811260802o188b4f30yfcbe23e13afe120e () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


stop drug alexis
stop drug alexis

forget the last mail.

On Wed, Nov 26, 2008 at 4:54 PM, Alexis M=E9nard <menard@kde.org> wrote:

> Ok so i keep the reimplentation and i remove the setFocus only, and i cal=
l
> the base class.
>
> 2008/11/26 Aaron J. Seigo <aseigo@kde.org>
>
>> On Wednesday 26 November 2008, Alexis M=E9nard wrote:
>> > Hello,
>> >
>> > Here is a patch that remove the focus stuff in the mousePressEvent of
>> > Applet class and remove the overload. Why? Because Qt have a focus
>> policy
>> > that manage that for you. It break the binary compatibilty but it not
>> too
>> > late no? :D.
>> > I think it will avoid some future problems regarding focus.
>> >
>> > Review please?
>>
>> you can do this without breaking BC, obviously. i'd like us to get in th=
e
>> habit of doing so and in this case it keeps the door open for adding
>> something
>> to that method if needed later on.
>>
>> --
>> Aaron J. Seigo
>> humru othro a kohnu se
>> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>>
>> KDE core developer sponsored by Qt Software
>>
>>
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>>
>

[Attachment #5 (text/html)]

stop drug alexis<br>stop drug alexis<br><br>forget the last mail.<br><br><div \
class="gmail_quote">On Wed, Nov 26, 2008 at 4:54 PM, Alexis Ménard <span \
dir="ltr">&lt;<a href="mailto:menard@kde.org">menard@kde.org</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Ok so i keep the \
reimplentation and i remove the setFocus only, and i call the base class.<br> \
<br><div class="gmail_quote">2008/11/26 Aaron J. Seigo <span dir="ltr">&lt;<a \
href="mailto:aseigo@kde.org" target="_blank">aseigo@kde.org</a>&gt;</span><br> \
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); \
margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div></div><div \
class="Wj3C7c"><div><div></div><div>On Wednesday 26 November 2008, Alexis Ménard \
wrote:<br>

&gt; Hello,<br>
&gt;<br>
&gt; Here is a patch that remove the focus stuff in the mousePressEvent of<br>
&gt; Applet class and remove the overload. Why? Because Qt have a focus policy<br>
&gt; that manage that for you. It break the binary compatibilty but it not too<br>
&gt; late no? :D.<br>
&gt; I think it will avoid some future problems regarding focus.<br>
&gt;<br>
&gt; Review please?<br>
<br>
</div></div>you can do this without breaking BC, obviously. i&#39;d like us to get in \
the<br> habit of doing so and in this case it keeps the door open for adding \
something<br> to that method if needed later on.<br>
<font color="#888888"><br>
--<br>
Aaron J. Seigo<br>
humru othro a kohnu se<br>
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA &nbsp;EE75 D6B7 2EB1 A7F1 DB43<br>
<br>
KDE core developer sponsored by Qt Software<br>
<br>
</font><br></div></div>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org" target="_blank">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br> </blockquote></div><br>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]