[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: new meter theming approach
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2008-10-24 10:24:03
Message-ID: 20081024102403.9378.26644 () vidsolbach ! de
[Download RAW message or body]



> On 2008-10-23 23:19:59, Petri Damstén wrote:
> > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp, line 122
> > <http://reviewboard.vidsolbach.de/r/239/diff/1/?file=1278#file1278line122>
> > 
> > * Fixed tile width/height ratio?
> > 

yeah, kinda, since panelsvg does not really have "natural sizes" since is not an \
element but a collection of them the idea is to make tiles near to golden ratio, but \
sligthly modified to fit an integer number of them, it's still not perfect because \
sometimes the margin is too much anyways, better ideas?


> On 2008-10-23 23:19:59, Petri Damstén wrote:
> > /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp, line 96
> > <http://reviewboard.vidsolbach.de/r/239/diff/1/?file=1278#file1278line96>
> > 
> > Can we do thermometer like meters (not tiled) with the new svg format (And is old \
> > svg format deprecated or just alternative way)?.

yes, the old one still works, can be used to make solid progressbars or yeah, \
termomenters (hmm would need an additional id for the bulb that shouldn't be scaled \
or at least scaled always with a 1:1 ratio)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/239/#review233
-----------------------------------------------------------


On 2008-10-23 14:24:23, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/239/
> -----------------------------------------------------------
> 
> (Updated 2008-10-23 14:24:23)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> the old theming for Plasma::Meter deformed the bar way too much when it was resized \
> too wide this uses panelsvg and tiling to do the image, and there is the new \
> theme.. it should be retrocompatible with old themes, still falls back at the old \
> elements 
> it does have a problem, when the number of tiles is not integer  it rounds to the \
> lower integer and mover the progressbar pattern at the centr, so there are little \
> margins at both sides. maybe not reeally pretty but still better than the deformed \
> old one i think 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp
> /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_horizontal.svgz
> /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_vertical.svgz
> 
> Diff: http://reviewboard.vidsolbach.de/r/239/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
> http://reviewboard.vidsolbach.de/r/239/s/84/
> 
> 
> Thanks,
> 
> Marco
> 
> 

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]