[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: new meter theming approach
From: Petri_Damstén <petri.damsten () gmail ! com>
Date: 2008-10-24 6:19:49
Message-ID: 20081024061949.4495.45592 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/239/#review233
-----------------------------------------------------------
Looks good.
/trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp
<http://reviewboard.vidsolbach.de/r/239/#comment185>
Can we do thermometer like meters (not tiled) with the new svg format (And is old \
svg format deprecated or just alternative way)?.
/trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp
<http://reviewboard.vidsolbach.de/r/239/#comment184>
* Fixed tile width/height ratio?
- Petri
On 2008-10-23 14:24:23, Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/239/
> -----------------------------------------------------------
>
> (Updated 2008-10-23 14:24:23)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> the old theming for Plasma::Meter deformed the bar way too much when it was resized \
> too wide this uses panelsvg and tiling to do the image, and there is the new \
> theme.. it should be retrocompatible with old themes, still falls back at the old \
> elements
> it does have a problem, when the number of tiles is not integer it rounds to the \
> lower integer and mover the progressbar pattern at the centr, so there are little \
> margins at both sides. maybe not reeally pretty but still better than the deformed \
> old one i think
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/libs/plasma/widgets/meter.cpp
> /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_horizontal.svgz
> /trunk/KDE/kdebase/workspace/plasma/desktoptheme/widgets/bar_meter_vertical.svgz
>
> Diff: http://reviewboard.vidsolbach.de/r/239/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
>
> http://reviewboard.vidsolbach.de/r/239/s/84/
>
>
> Thanks,
>
> Marco
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic